Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcl_logging_interface is only valid path with build environment. (backport #122) #125

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 1, 2024

closes #121


This is an automatic backport of pull request #122 done by Mergify.

* logging impls need to export dependency for 'rcl_logging_interface'.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 0724aeb)

# Conflicts:
#	rcl_logging_noop/CMakeLists.txt
#	rcl_logging_spdlog/CMakeLists.txt
@mergify mergify bot added the conflicts label Oct 1, 2024
Copy link
Author

mergify bot commented Oct 1, 2024

Cherry-pick of 0724aeb has failed:

On branch mergify/bp/humble/pr-122
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 0724aeb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rcl_logging_noop/CMakeLists.txt
	both modified:   rcl_logging_spdlog/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@clalancette
Copy link
Contributor

Closing, as this isn't needed on humble (it already has the export).

@clalancette clalancette closed this Oct 1, 2024
@clalancette clalancette deleted the mergify/bp/humble/pr-122 branch October 1, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants