fix rclc_example: memory leaking in msg.data allocation (backport #386) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> Co-authored-by: zhangtonghe <zhangtonghe@megvii.com> (cherry picked from commit 7af2054)
JanStaschulat
approved these changes
Jul 28, 2023
|
https://build.ros2.org/job/Rpr__rclc__ubuntu_jammy_amd64/163/clang-tidy/new/folder.-84953004/ |
fujitatomoya
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
this fix is not related to https://build.ros2.org/job/Rpr__rclc__ubuntu_jammy_amd64/163/clang-tidy/new/folder.-84953004/category.2119183113/. but as mentioned here, tick-tock deprecate introduced on ros2/rcl#1004 leads to this warning.
* fix: deprecated rcl_timer_init Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> * fix: switch rcl_timer_init to rcl_timer_init2 Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> * update rclc_timer_init_default and it's invokation Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> * Revert "update rclc_timer_init_default and it's invokation" This reverts commit ebc3edb. Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> * fix: rcl_timer_init usage Combined changes from multiple commits to refactor the usage of rcl_timer_init for better compatibility and clarity. Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> * Update rclc/include/rclc/timer.h Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> --------- Signed-off-by: Zard-C <patrick.zhang5233@gmail.com> Signed-off-by: zhangtonghe <zhangtonghe@megvii.com> Co-authored-by: zhangtonghe <zhangtonghe@megvii.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Codecov Report
@@ Coverage Diff @@
## rolling #387 +/- ##
===========================================
- Coverage 69.63% 69.44% -0.20%
===========================================
Files 16 16
Lines 2760 2762 +2
Branches 766 766
===========================================
- Hits 1922 1918 -4
- Misses 452 456 +4
- Partials 386 388 +2
|
|
I made DCO check pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #386 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com