-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the void (shared_ptr<MessageT>)
subscription callback signatures
#1619
Labels
enhancement
New feature or request
Comments
@wjwwood I can do this quick patch if that's fine. |
aprotyas
pushed a commit
that referenced
this issue
Jul 13, 2021
Addresses #1619. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
aprotyas
pushed a commit
that referenced
this issue
Aug 20, 2021
Addresses #1619. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
aprotyas
pushed a commit
that referenced
this issue
Aug 26, 2021
…tures (#1713) * Deprecated `shared_ptr<MessageT>` sub callbacks Addresses #1619. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org> * Resolve deprecated subscription callbacks in tests Specifically, `void shared_ptr<MessageT>` subscription callbacks have been migrated to `void shared_ptr<const MessageT>` subscription callbacks. This change has been performed only on the test files that do not actually house unit tests for the `AnySubscriptionCallback` class. For unit tests that actually target the deprecated `set` functions, the deprecation warnings have to be avoided. This patch will be introduced in a separate commit. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org> * Suppress deprecation warnings in unit tests This commit specifically introduces suppression of the deprecation warnings produced while compiling unit tests for the `AnySubscriptionCallback` class. The macro mechanics to conditionally include the `deprecated` attribute is not ideal, but the diagnostic pragma solution (`# pragma GCC diagnostic ignored`) did not work for these unit tests, possibly because of the way gtest is initializing the necessary `InstanceContext` objects. A `TODO` directive has been left to figure out a better way to address this warning suppression. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org> * Fix shared ptr callback in wait_for_message Moving away from deprecated signatures. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org> * `rclcpp_action`: Fix deprecated subscr. callbacks Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org> * `rclcpp_lifecycle`: Fix deprecated sub callbacks Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
Closing this issue following the merge of #1713. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We decided we wanted to do this (see discussion here: #1598 (comment)), but decided against doing it so close to the Galactic API freeze.
These are signatures in question:
rclcpp/rclcpp/include/rclcpp/any_subscription_callback.hpp
Lines 192 to 214 in 1037822
The text was updated successfully, but these errors were encountered: