External parameters api #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easier to read diff developer-parameters-api...external-parameters-api |
Merged
esteve
force-pushed
the
external-parameters-api
branch
from
b7aede0
to
cf48904
Compare
esteve
force-pushed
the
external-parameters-api
branch
from
cf48904
to
23e1ab4
Compare
|
lgtm |
|
+1 |
|
Thanks for the reviews. I'm working on parameter events, but I'll submit the changes in a followup branch. |
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Jan 15, 2021
Asoragna/cleanup events exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the service-based parameter API.
Connects to ros2/ros2#28
Depends on #31
@dirk-thomas @tfoote @wjwwood please review