Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to parameter.py. #1246

Merged
merged 27 commits into from
Aug 2, 2024
Merged

Add types to parameter.py. #1246

merged 27 commits into from
Aug 2, 2024

Commits on Mar 27, 2024

  1. Add types to parameter.py 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    51d410d View commit details
    Browse the repository at this point in the history

  2. Revert "Add types to TypeHash and moved away from __slots__ usage (ro… 

    …s2#1232)" (ros2#1243)

This reverts commit b06baef.

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @clalancette @InvincibleRMC
    clalancette authored and InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7661294 View commit details
    Browse the repository at this point in the history

  3. Add back Type hash __slots__ and add test cases. (ros2#1245) 

    * Add types to TypeHash and add test cases

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    98ba24c View commit details
    Browse the repository at this point in the history

  4. Add types to context.py (ros2#1240) 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c60ba6f View commit details
    Browse the repository at this point in the history

  5. Add types to qos_overriding_options.py (ros2#1248) 

    Signed-off-by: Michael Carlstrom <rmc170@case.edu>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0bca600 View commit details
    Browse the repository at this point in the history

  6. Small fixes for modern flake8. (ros2#1264) 

    It doesn't like to compare types with ==, so switch to
isinstance as appropriate.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @clalancette @InvincibleRMC
    clalancette authored and InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    51889a4 View commit details
    Browse the repository at this point in the history

  7. Add types to time_source.py (ros2#1259) 

    * Add types to time_source.py

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6b5b793 View commit details
    Browse the repository at this point in the history

  8. fix small bug 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fe29332 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'rolling' into parameters

    @InvincibleRMC
    InvincibleRMC committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2bd92ed View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'rolling' into parameters

    @InvincibleRMC
    InvincibleRMC committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e879246 View commit details
    Browse the repository at this point in the history

  2. Switch to overloads to avoid mypy3737 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 30, 2024
    Configuration menu
    Copy the full SHA
    2655545 View commit details
    Browse the repository at this point in the history

  3. Update parameter declaration from Node 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 30, 2024
    Configuration menu
    Copy the full SHA
    dc58c0b View commit details
    Browse the repository at this point in the history

  4. add back rclpy. 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 30, 2024
    Configuration menu
    Copy the full SHA
    da1251b View commit details
    Browse the repository at this point in the history

  5. Fix flake8 imports 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f7fa348 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Add proper array.array[] 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d60df58 View commit details
    Browse the repository at this point in the history

  2. Update types of declare_parameter, declare_parameters api 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    44f4fba View commit details
    Browse the repository at this point in the history

  3. Add non conflicting types back to constructor 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8c56519 View commit details
    Browse the repository at this point in the history

  4. Move sys import 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7f36fa2 View commit details
    Browse the repository at this point in the history

  5. Update error message 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5fba36d View commit details
    Browse the repository at this point in the history

  6. Add default value for generic Parameter 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f2466c1 View commit details
    Browse the repository at this point in the history

  7. Add explanation comment 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f01ca94 View commit details
    Browse the repository at this point in the history

  8. Add TypeVar import inside else case 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a646d8a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'rolling' into parameters

    @InvincibleRMC
    InvincibleRMC committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    23c828a View commit details
    Browse the repository at this point in the history

  2. push to rerun ci 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6acc79c View commit details
    Browse the repository at this point in the history

  3. push to rerun ci 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    739b97a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Switch back to union 

    Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
    @InvincibleRMC
    InvincibleRMC committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ae10551 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Merge remote-tracking branch 'upstream/rolling' into parameters

    @sloretz
    sloretz committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    480dfe4 View commit details
    Browse the repository at this point in the history