disable 1kHz test on all platforms #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in progress
|
|
I would suggest to use an annotation instead. |
This reverts commit 758a74f.
Done in 39bf6db |
dirk-thomas
approved these changes
Aug 15, 2018
dirk-thomas
reviewed
Aug 15, 2018
rclpy/test/test_timer.py
Outdated
| @@ -15,6 +15,7 @@ | |||
| import multiprocessing | |||
| import os | |||
| import platform | |||
| import pytest | |||
There was a problem hiding this comment.
This might need a test dependency?
There was a problem hiding this comment.
Absolutely. I would expect it to always be provided by ament_cmake_pytest but it's better to be explicit. Added in 599edd7
dirk-thomas
approved these changes
Aug 15, 2018
|
CI as of a850ae0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these tests fail more and more often on all platforms (e.g. here)
Disabling the 1kHz test on all platforms for now until we decide how to refactor them