Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable 1kHz test on all platforms #223

Merged
merged 6 commits into from
Aug 15, 2018
Merged

disable 1kHz test on all platforms #223

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
758a74f
disable 1kHz test on all platforms
mikaelarguedas Aug 15, 2018
88ff1a2
Revert "disable 1kHz test on all platforms"
mikaelarguedas Aug 15, 2018
39bf6db
mark 1kHz tests as skipped
mikaelarguedas Aug 15, 2018
599edd7
add pytest as test dependency
mikaelarguedas Aug 15, 2018
4efbd4b
use single quotes
dirk-thomas Aug 15, 2018
a850ae0
fix import order
mikaelarguedas Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rclpy/test/test_timer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import multiprocessing
import os
import platform
import pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a test dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. I would expect it to always be provided by ament_cmake_pytest but it's better to be explicit. Added in 599edd7

import sys
import time
import traceback
Expand Down Expand Up @@ -152,6 +153,7 @@ def test_timer_zero_callbacks100hertz():
# TODO(mikaelarguedas) reenable these once timer have consistent behaviour
# on every platform at high frequency
# TODO(sloretz) Reenable on arm when executor performance is good enough
@pytest.mark.skip(reason="1kHz tests are too prone to flakiness")
def test_timer_zero_callbacks1000hertz():
if os.name == 'nt' or platform.machine() == 'aarch64':
raise SkipTest
Expand All @@ -167,6 +169,7 @@ def test_timer_number_callbacks100hertz():
func_number_callbacks, ['0.01'], "didn't receive the expected number of callbacks")


@pytest.mark.skip(reason="1kHz tests are too prone to flakiness")
def test_timer_number_callbacks1000hertz():
if os.name == 'nt' or platform.machine() == 'aarch64':
raise SkipTest
Expand All @@ -184,6 +187,7 @@ def test_timer_cancel_reset_100hertz():
func_cancel_reset_timer, ['0.01'], "didn't receive the expected number of callbacks")


@pytest.mark.skip(reason="1kHz tests are too prone to flakiness")
def test_timer_cancel_reset_1000hertz():
if os.name == 'nt' or platform.machine() == 'aarch64':
raise SkipTest
Expand Down