Skip to content

Create sublogger for action server and action client #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2022
Merged

Create sublogger for action server and action client #982

merged 4 commits into from
Jul 28, 2022

Conversation

@tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Jul 27, 2022 •
edited
Loading

Addresses #969

@tonynajjar tonynajjar mentioned this pull request Jul 27, 2022
Closed
add global loggers
54a820f 
Signed-off-by: Tony Najjar <tony.najjar@logivations.com>
fujitatomoya
fujitatomoya approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with DCO fix.

@tonynajjar tonynajjar changed the title Add global loggers Add rclpy_action loggers Jul 27, 2022
@fujitatomoya
Copy link
Collaborator

@sloretz @ivanpauno either of you could do another review on this?

@tonynajjar
Copy link
Contributor Author

@sloretz @ivanpauno either of you could do another review on this?

Please do, it was a quick fix for us, I did not test this extensively or gave it much more thought

ivanpauno
ivanpauno reviewed Jul 27, 2022
View reviewed changes
get child logger
f5a05ea 
Signed-off-by: Tony Najjar <tony.najjar@logivations.com>
@tonynajjar tonynajjar requested review from ivanpauno and sloretz July 27, 2022 19:48
fix typo
bb9162b 
Signed-off-by: Tony Najjar <tony.najjar@logivations.com>
ivanpauno
ivanpauno approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

remove import
e3bc8b1 
Signed-off-by: Tony Najjar <tony.najjar@logivations.com>
ivanpauno
ivanpauno approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno
Copy link
Member

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ivanpauno ivanpauno changed the title Add rclpy_action loggers Create sublogger for action server and action client Jul 28, 2022
@ivanpauno ivanpauno merged commit 1d0cc63 into ros2:rolling Jul 28, 2022
tonynajjar added a commit to pixel-robotics/rclpy that referenced this pull request Oct 26, 2022
@tonynajjar
Create sublogger for action server and action client (ros2#982)
78ada4b 
Signed-off-by: Tony Najjar <tony.najjar@logivations.com>
@tonynajjar tonynajjar mentioned this pull request Feb 14, 2023
Closed
@sea-bass sea-bass mentioned this pull request Nov 1, 2023
Closed
@hello-amal
Copy link

hello-amal commented Jun 3, 2024 •
edited
Loading

Could we get a Humble backport of this?

Humble has a bug where in certain error cases, it tries to access self._logger, but self._logger doesn't exist (e.g., here). This PR would address that, since it creates a self._logger.

@sloretz sloretz mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tonynajjar @fujitatomoya @ivanpauno @hello-amal @sloretz