Enable logging level manipulation from rmw_fastrtps #156

sriramster · 2017-10-13T14:20:50Z

To enable the same, enable setting log levels from rmw_fastrtps layers,
Add generic logging level parameters to 'rmw.h' which would be used by other
layers above like rcl/rclcpp.
Hide DDS specific implementation inside rmw_fastrtps.

Remove log level setting from rmw_create_node, as the idea of the API is to purely create a node than setting up fastrtps.

Signed-off-by: Sriram Raghunathan sriram.max@gmail.com

Connect to ros2/rmw#124

… ros2 development. * To enable the same, enable setting log levels from rmw_fastrtps layers, * Add generic logging level parameters to 'rmw.h' which would be used by other layers above like rcl/rclcpp. * Hide DDS specific implementation inside rmw_fastrtps. Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

dirk-thomas · 2017-10-13T16:28:06Z

Functions which are not defined in the rmw interface should not be prefixed with rmw_.

In the related PR ros2/rmw#124 it doesn't add any function or argument to the rmw interface to pass a log severity. How do you plan to pass the parameter?

sriramster · 2017-10-13T16:33:53Z

Need some help with it, I've not experimented with the other DDS implementations. This patch set, was specific to fastrtps. And, needed a review comment to check if its ok to add an rmw_ interface to set log levels from upper layers, which for now is specific only to fastrtps. Let me know.

dirk-thomas · 2017-10-13T16:40:50Z

First the rmw interface needs to be updated, either by:

adding a parameter to the rmw_init function or
by adding a new function

Once we agree on the interface change all rmw implementations need to be updated in order to match the updated interface. Currently these are rmw_fastrtps, rmw_connext, rmw_opensplice and the package rmw_implemenation.

sriramster · 2017-10-13T17:10:24Z

One reason why I avoided modifying rmw_init was, I'd a theoretical guess here that rmw_init would do more than just configuring logging parameters. So i'd thought.

Create a different function for setting up logging, and call this API from inside rmw_init();

Let me know if this goes with the idea of ros's core principles.

dirk-thomas · 2017-10-13T17:13:24Z

One reason why I avoided modifying rmw_init was, I'd a theoretical guess here that rmw_init would do more than just configuring logging parameters. So i'd thought.

That is true. We could certainly add a separate function for it. But if rmw_init and rmw_set_log_level are then always being called together then a parameter would be fine too. @ros2/team What do others prefer?

dhood · 2017-10-13T17:20:53Z

If rmw_set_log_level were a separate function it'd be easier to call it if someone wants to change the level at runtime (assuming the vendor's logging supports runtime changes)

sriramster · 2017-10-13T17:23:02Z

Adding, to the comment from @dhood , an API also gives the userspace ros application developer to control it from an application code.

mikaelarguedas · 2017-10-13T17:44:30Z

Agreed with @dhood and @jwang11. An API would also give more granularity, I think in most cases a user would want to see the INFO output of a node without having all the INFO output of the underlying rmw_implementation.

Edit: I guess it was unclear in my previous comment, I just wanted to point out an example of runtime configuration. One could start with a low threshold for the ros node and high threshold for the rmw_impl and dynamically change the rmw_impl threshold when the messages printed in the node are not enough for debugging.

dirk-thomas · 2017-10-13T17:47:04Z

Sounds like we have a consensus to add a new function to the rmw interface to set the log level 👍

I think in most cases a user would want to see the INFO output of a node without having all the INFO output of the underlying rmw_implementation.

This is unrelated to the question how the parameter is passed to rmw.

sriramster · 2017-10-13T17:59:09Z

The parameter needs to be set by a native call to rmw_implementation. Since doing it from elsewhere would change code at multiple layers.

ros2/rmw#124 * The API defined is used to set the logging level particular to the DDS implementation. * This change is specific to DDS type Fast-RTPS. * The file is named as rmw_configure since we could write API's of type 'system level config setting' types here. Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>

… the patterns being used already. like rmw_node, rmw_publisher.. Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

sriramster · 2017-10-25T08:44:30Z

@dirk-thomas Have updated the fastrtps specific logging here. Please let me know if these changes are fine.

dirk-thomas

Please do the following locally:

make sure the code compiles (which it currently doesn't)
run the tests (and update the code style to pass the linters)

Also this currently has conflicts and needs to be rebased in order to be mergable.

dirk-thomas · 2017-10-25T17:02:39Z

rmw_fastrtps_cpp/CMakeLists.txt

@@ -61,6 +61,7 @@ add_library(rmw_fastrtps_cpp
  src/namespace_prefix.cpp
  src/qos.cpp
  src/rmw_init.cpp
+  src/rmw_fastrtps_configure.cpp


This file doesn't exist. This should probably be rmw_logging.cpp.

dirk-thomas · 2017-10-25T17:03:17Z

rmw_fastrtps_cpp/src/rmw_logging.cpp

+{
+using eprosima::fastrtps::Log;
+
+eprosima::fastrtps::Log::Kind rmw_convert_severity_type(rmw_log_severity_t severity)


As mentioned before: functions not defined in the rmw interface should not be prefixed with rmw_.

- Renmae API to suite ros styles Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

sriramster · 2017-10-26T08:13:43Z

@dirk-thomas Sorry for the errors. I've fixed them. I was'nt aware of testing, so missed it. I've run the test build as well. Let me know if anything else to be done.

dirk-thomas · 2017-10-26T18:02:09Z

rmw_fastrtps_cpp/src/rmw_logging.cpp

+       //Fallback to Info if undefined types
+       return Log::Kind::Info;
+  }
+}


This code block currently doesn't pass the linter tests. Please run the linters (either with ament test or directly ament_uncrustify / ament_cpplint) and address the style warnings.

dirk-thomas · 2017-10-26T18:04:40Z

Let me know if anything else to be done.

Currently the branch has conflicts and can't be merged. Please rebase your branch to be mergable with master.

Also are you planning on providing similar PRs for rmw_connext and rmw_opensplice? The set of PRs can only be merged once all currently supported rmw impl. implement the new function (even if the new function doesn't do anything for some rmw impl.).

Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

sriramster · 2017-10-29T09:18:51Z

@dirk-thomas Have fixed the issues pending. Sorry for this delay, this was my first patch so had to learn a few ros specific disciplines. Let me know if you've any task that I could take up purely as a student and contribute back. Thanks for the patience.

…iram_beta3

dirk-thomas · 2017-10-30T18:53:50Z

Please do not make unrelated changes within the same pull request. Keep the focus of this PR on function to set the logging severity.

Unrelated changes like the use of RMW_CHECK_TYPE_IDENTIFIERS_MATCH should go into separate pull requests.

sriramster · 2017-10-31T12:39:14Z

@dirk-thomas done. That was supposed to be my next pull request. Mixed it up.

dirk-thomas

Please run the tests of the package after modifying the code. I expect it to flag several style warnings.

dirk-thomas · 2017-11-06T21:15:46Z

rmw_fastrtps_cpp/src/rmw_logging.cpp

+  case RMW_LOG_SEVERITY_ERROR:
+  case RMW_LOG_SEVERITY_FATAL:
+  case RMW_LOG_SEVERITY_DEBUG:
+       return Log::Kind::Error;


I don't think that Log::Kind::Error is a reasonable mapping for RMW_LOG_SEVERITY_DEBUG.

dirk-thomas · 2017-11-06T21:16:36Z

rmw_fastrtps_cpp/src/rmw_logging.cpp

+rmw_set_log_severity(rmw_log_severity_t severity)
+{
+  Log::Kind _severity = convert_rmw_severity_type(severity);
+  eprosima::fastrtps::Log::SetVerbosity(_severity);


If the severity can't be mapped (the default case in the other function) it might be better to print an error message rather than setting a fallback level without letting the user know.

@dirk-thomas ok. In that case I'll have to change the API to return a type rmw_ret_t. And, may I use RMW_SET_ERROR_MSG for error setting on unknown types? There has been instances where inside rmw RCUTILS macro for error logging has been used. Let me know on this.

@dirk-thomas Could you let me know your thoughts on the previous comment?

Since this function is private, only being used once in the same .cpp file, and the calling function is only a couple of lines ong I would suggest to just remove the separate function and move the implementation into rmw_set_log_severity. That would simplify the code. rmw_set_log_severity can then indeed return an error code and set the error message accordingly.

Ok. Thanks. I'll make the necessary changes and update the commit.

…g logging Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>

sriramster · 2017-11-19T17:45:22Z

@dirk-thomas Sorry about the delay in addressing the review comments. I've pushed in the changes with latest review comments. Please have a look.

sriramster · 2017-11-27T12:19:05Z

@dirk-thomas Could you have a look at the updated pull request?

sriramster · 2017-12-12T06:25:45Z

@dirk-thomas Hi Dirk, Could you have a look the above commit? And let me know if this is ok.

dirk-thomas

My previous comment (#156 (comment)) is still pending.

dirk-thomas · 2017-12-13T09:42:35Z

rmw_fastrtps_cpp/src/rmw_logging.cpp

+      _severity = Log::Kind::Error;
+      break;
+    default:
+      RMW_SET_ERROR_MSG("node handle is null");


This error message seems to not match the case.

@dirk-thomas Updated the commit with logging msg. Please have a look.

sriramster · 2017-12-19T06:36:39Z

@dirk-thomas Could you review the latest change set?

dirk-thomas · 2017-12-19T07:16:38Z

rmw_fastrtps_cpp/src/rmw_logging.cpp

+// From rmw logging severity there is FATAL severity type we map it
+// to ERROR type of Fast-RTPS which has maximum priority
+    case RMW_LOG_SEVERITY_DEBUG:
+      _severity = Log::Kind::Warning;


This mapping still doesn't make any sense. The expectation is that DEBUG is more verbose than INFO. Therefore mapping it to Warning were INFO is mapped to Info seems wrong to me. I think this needs to be Info instead.

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>

sriramster · 2017-12-19T08:41:25Z

@dirk-thomas Thanks. Had a theoretical reasoning mapping Debug to Warning type of fastrtps, like mentioned Warning was verbose than info. And felt debug messages needed to be more verbose. Anyways fixed it like you suggested. Please have a look.

…severity in error message

dirk-thomas · 2017-12-19T08:56:47Z

I refactored the patch slightly in a01006a. This looks good to me now.

I will wait with merging this for the similar PRs on the other rmw impl.

sriramster · 2017-12-26T16:10:11Z

@dirk-thomas Thank you.

ros-rolling-rmw-fastrtps-cpp (6.2.1-1jammy) jammy; urgency=high . * Add pub/sub init, publish and take instrumentation using tracetools (#591 <ros2/rmw_fastrtps#591>) * Add content filter topic feature (#513 <ros2/rmw_fastrtps#513>) * Add sequence numbers to message info structure (#587 <ros2/rmw_fastrtps#587>) * Removed some heap interactions in rmw_serialize.cpp (#590 <ros2/rmw_fastrtps#590>) * Contributors: Chen Lihui, Christophe Bedard, Ivan Santiago Paunovic, WideAwakeTN . ros-rolling-rmw-fastrtps-cpp (6.2.0-1jammy) jammy; urgency=high . * Add EventsExecutor (#468 <ros2/rmw_fastrtps#468>) * Install headers to include/${PROJECT_NAME} (#578 <ros2/rmw_fastrtps#578>) * Contributors: Shane Loretz, iRobot ROS . ros-rolling-rmw-fastrtps-cpp (6.1.2-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (6.1.1-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (6.1.0-1jammy) jammy; urgency=high . * Add client/service QoS getters. (#560 <ros2/rmw_fastrtps#560>) * Contributors: mauropasse . ros-rolling-rmw-fastrtps-cpp (6.0.0-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (5.2.2-1jammy) jammy; urgency=high . * Correctly recalculate serialized size on bounded sequences. (#540 <ros2/rmw_fastrtps#540>) * Fix type size alignment. (#550 <ros2/rmw_fastrtps#550>) * Contributors: Miguel Company . ros-rolling-rmw-fastrtps-cpp (5.2.1-1jammy) jammy; urgency=high . * Change links from index.ros.org -> docs.ros.org (#539 <ros2/rmw_fastrtps#539>) * Contributors: Chris Lalancette . ros-rolling-rmw-fastrtps-cpp (5.2.0-1jammy) jammy; urgency=high . * Add rmw_publisher_wait_for_all_acked support. (#519 <ros2/rmw_fastrtps#519>) * Contributors: Barry Xu . ros-rolling-rmw-fastrtps-cpp (5.1.0-1jammy) jammy; urgency=high . * Loan messages implementation (#523 <ros2/rmw_fastrtps#523>) * Added is_plain_ attribute to base TypeSupport. * Added new methods to base TypeSupport. * Implementation of rmw_borrow_loaned_message. * Implementation of rmw_return_loaned_message_from_publisher. * Enable loan messages on publishers of plain types. * Implementation for taking loaned messages. * Enable loan messages on subscriptions of plain types. * Contributors: Miguel Company . ros-rolling-rmw-fastrtps-cpp (5.0.0-1jammy) jammy; urgency=high . * Refactor to use DDS standard API (#518 <ros2/rmw_fastrtps#518>) * Unique network flows (#502 <ros2/rmw_fastrtps#502>) * updating quality declaration links (re: ros2/docs.ros2.org#52 <ros2/docs.ros2.org#52>) (#520 <ros2/rmw_fastrtps#520>) * Contributors: Miguel Company, shonigmann . ros-rolling-rmw-fastrtps-cpp (4.5.0-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (4.4.0-1jammy) jammy; urgency=high . * Add RMW function to check QoS compatibility (#511 <ros2/rmw_fastrtps#511>) * Capture cdr exceptions (#505 <ros2/rmw_fastrtps#505>) * Contributors: Jacob Perron, Miguel Company . ros-rolling-rmw-fastrtps-cpp (4.3.0-1jammy) jammy; urgency=high . * Load profiles based on topic names (#335 <ros2/rmw_fastrtps#335>) * Set rmw_dds_common::GraphCache callback after init succeeds. (#496 <ros2/rmw_fastrtps#496>) * Handle typesupport errors on fetch. (#495 <ros2/rmw_fastrtps#495>) * Contributors: Eduardo Ponz Segrelles, Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (4.2.0-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (4.1.0-1jammy) jammy; urgency=high . * Check for correct context shutdown (#486 <ros2/rmw_fastrtps#486>) * New environment variable to change easily the publication mode (#470 <ros2/rmw_fastrtps#470>) * Contributors: Ignacio Montesino Valle, José Luis Bueno López . ros-rolling-rmw-fastrtps-cpp (4.0.0-1jammy) jammy; urgency=high . * Discriminate when the Client has gone from when the Client has not completely matched (#467 <ros2/rmw_fastrtps#467>) * Workaround when the client is gone before server sends response * Change add to the map to listener callback * Update the package.xml files with the latest Open Robotics maintainers (#459 <ros2/rmw_fastrtps#459>) * Update Quality Declarations and READMEs (#455 <ros2/rmw_fastrtps#455>) * Add QD links for dependencies to rmw_fastrtps_cpp QD * Provide external dependencies QD links * Update rmw_fastrtps README to use Fast DDS * Update rmw_fastrtps_cpp QD: Fast DDS & unit test * Update README rmw_fastrtps_cpp to QL2 * Contributors: JLBuenoLopez-eProsima, Jaime Martin Losa, José Luis Bueno López, Michael Jeronimo . ros-rolling-rmw-fastrtps-cpp (3.1.4-1jammy) jammy; urgency=high . * Perform fault injection in all creation/destruction APIs. (#453 <ros2/rmw_fastrtps#453>) * Ensure rmw_destroy_node() completes despite run-time errors. (#458 <ros2/rmw_fastrtps#458>) * Update rmw_fastrtps_cpp and rmw_fastrtps_shared_cpp QDs to QL2. (#456 <ros2/rmw_fastrtps#456>) * Contributors: Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (3.1.3-1jammy) jammy; urgency=high . * Return RMW_RET_UNSUPPORTED in rmw_get_serialized_message_size (#452 <ros2/rmw_fastrtps#452>) * Contributors: Alejandro Hernández Cordero . ros-rolling-rmw-fastrtps-cpp (3.1.2-1jammy) jammy; urgency=high . * Updated publisher/subscription allocation and wait set API return codes (#443 <ros2/rmw_fastrtps#443>) * Added rmw_logging tests (#442 <ros2/rmw_fastrtps#442>) * Contributors: Alejandro Hernández Cordero . ros-rolling-rmw-fastrtps-cpp (3.1.1-1jammy) jammy; urgency=high . * Make service/client construction/destruction implementation compliant (#445 <ros2/rmw_fastrtps#445>) * Make sure type can be unregistered successfully (#437 <ros2/rmw_fastrtps#437>) * Contributors: Barry Xu, Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (3.1.0-1jammy) jammy; urgency=high . * Add tests for native entity getters. (#439 <ros2/rmw_fastrtps#439>) * Avoid deadlock if graph update fails. (#438 <ros2/rmw_fastrtps#438>) * Contributors: Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (3.0.0-1jammy) jammy; urgency=high . * Call Domain::removePublisher while failure occurs in create_publisher (#434 <ros2/rmw_fastrtps#434>) * Contributors: Barry Xu . ros-rolling-rmw-fastrtps-cpp (2.6.0-1jammy) jammy; urgency=high . * Ensure compliant matched pub/sub count API. (#424 <ros2/rmw_fastrtps#424>) * Ensure compliant publisher QoS queries. (#425 <ros2/rmw_fastrtps#425>) * Contributors: Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (2.5.0-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (2.4.0-1jammy) jammy; urgency=high . * Ensure compliant subscription API. (#419 <ros2/rmw_fastrtps#419>) * Contributors: Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (2.3.0-1jammy) jammy; urgency=high . * Ensure compliant publisher API. (#414 <ros2/rmw_fastrtps#414>) * Contributors: Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (2.2.0-1jammy) jammy; urgency=high . * Set context actual domain id (#410 <ros2/rmw_fastrtps#410>) * Contributors: Ivan Santiago Paunovic . ros-rolling-rmw-fastrtps-cpp (2.1.0-1jammy) jammy; urgency=high . * Ensure compliant node construction/destruction API. (#408 <ros2/rmw_fastrtps#408>) * Contributors: Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (2.0.0-1jammy) jammy; urgency=high . * Remove domain_id and localhost_only from node API (#407 <ros2/rmw_fastrtps#407>) * Amend rmw_init() implementation: require enclave. (#406 <ros2/rmw_fastrtps#406>) * Update Quality Declarations to QL3. (#404 <ros2/rmw_fastrtps#404>) * Contributors: Ivan Santiago Paunovic, Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (1.1.0-1jammy) jammy; urgency=high . * Ensure compliant init/shutdown API implementation. (#401 <ros2/rmw_fastrtps#401>) * Update Quality Declaration to QL3. (#403 <ros2/rmw_fastrtps#403>) * Finalize context iff shutdown. (#396 <ros2/rmw_fastrtps#396>) * Make service wait for response reader (#390 <ros2/rmw_fastrtps#390>) * Contributors: Michel Hidalgo, Miguel Company . ros-rolling-rmw-fastrtps-cpp (1.0.1-1jammy) jammy; urgency=high . * Add Security Vulnerability Policy pointing to REP-2006 (#389 <ros2/rmw_fastrtps#389>) * Update QDs for 1.0 (#383 <ros2/rmw_fastrtps#383>) * Contributors: Chris Lalancette, Stephen Brawner . ros-rolling-rmw-fastrtps-cpp (1.0.0-1jammy) jammy; urgency=high . * Remove API related to manual by node liveliness. (#379 <ros2/rmw_fastrtps#379>) * Update quality declarations on feature testing. (#380 <ros2/rmw_fastrtps#380>) * Contributors: Ivan Santiago Paunovic, Michel Hidalgo . ros-rolling-rmw-fastrtps-cpp (0.9.1-1jammy) jammy; urgency=high . * Add package READMEs and QUALITY_DECLARATION files (#375 <ros2/rmw_fastrtps#375>) * Added doxyfiles (#372 <ros2/rmw_fastrtps#372>) * Contributors: Alejandro Hernández Cordero, brawner . ros-rolling-rmw-fastrtps-cpp (0.9.0-1jammy) jammy; urgency=high . * Add missing export of rmw_dds_common. (#374 <ros2/rmw_fastrtps#374>) * Rename rosidl_message_bounds_t. (#373 <ros2/rmw_fastrtps#373>) * Feature/services timestamps. (#369 <ros2/rmw_fastrtps#369>) * Add support for taking a sequence of messages. (#366 <ros2/rmw_fastrtps#366>) * security-context -> enclave. (#365 <ros2/rmw_fastrtps#365>) * Rename rosidl_generator_c namespace to rosidl_runtime_c. (#367 <ros2/rmw_fastrtps#367>) * Remove custom typesupport for rmw_dds_common interfaces. (#364 <ros2/rmw_fastrtps#364>) * Added rosidl_runtime c and cpp depencencies. (#351 <ros2/rmw_fastrtps#351>) * Switch to one Participant per Context. (#312 <ros2/rmw_fastrtps#312>) * Add rmw_*_event_init() functions. (#354 <ros2/rmw_fastrtps#354>) * Fixing type support C/CPP mix on rmw_fastrtps_dynamic_cpp. (#350 <ros2/rmw_fastrtps#350>) * Fix build warning in Ubuntu Focal. (#346 <ros2/rmw_fastrtps#346>) * Code style only: wrap after open parenthesis if not in one line. (#347 <ros2/rmw_fastrtps#347>) * Passing down type support information (#342 <ros2/rmw_fastrtps#342>) * Implement functions to get publisher and subcription informations like QoS policies from topic name. (#336 <ros2/rmw_fastrtps#336>) * Contributors: Alejandro Hernández Cordero, Dirk Thomas, Ingo Lütkebohle, Ivan Santiago Paunovic, Jaison Titus, Miaofei Mei, Michael Carroll, Miguel Company, Mikael Arguedas . ros-rolling-rmw-fastrtps-cpp (0.8.1-1jammy) jammy; urgency=high . * use return_loaned_message_from (#334 <ros2/rmw_fastrtps#334>) * Restrict traffic to localhost only if env var is provided (#331 <ros2/rmw_fastrtps#331>) * Zero copy api (#322 <ros2/rmw_fastrtps#322>) * update signature for added pub/sub options (#329 <ros2/rmw_fastrtps#329>) * Contributors: Brian Marchi, Karsten Knese, William Woodall . ros-rolling-rmw-fastrtps-cpp (0.8.0-1jammy) jammy; urgency=high . * Add function for getting clients by node (#293 <ros2/rmw_fastrtps#293>) * Implement get_actual_qos() for subscriptions (#287 <ros2/rmw_fastrtps#287>) * Fix error message (#290 <ros2/rmw_fastrtps#290>) * Contributors: Jacob Perron, M. M . ros-rolling-rmw-fastrtps-cpp (0.7.3-1jammy) jammy; urgency=high . . . ros-rolling-rmw-fastrtps-cpp (0.7.2-1jammy) jammy; urgency=high . * Centralize topic name creation logic and update to match FastRTPS 1.8 API (#272 <ros2/rmw_fastrtps#272>) * Contributors: Nick Burek . ros-rolling-rmw-fastrtps-cpp (0.7.1-1jammy) jammy; urgency=high . * Support arbitrary message namespaces (#266 <ros2/rmw_fastrtps#266>) * Add qos interfaces with no-op (#271 <ros2/rmw_fastrtps#271>) * Updates for preallocation API. (#274 <ros2/rmw_fastrtps#274>) * Contributors: Jacob Perron, Michael Carroll, Ross Desmond . ros-rolling-rmw-fastrtps-cpp (0.7.0-1jammy) jammy; urgency=high . * Add function to get publisher actual qos settings (#267 <ros2/rmw_fastrtps#267>) * pass context to wait set and fini context (#252 <ros2/rmw_fastrtps#252>) * Improve service_is_available logic to protect that client is waiting forever (#238 <ros2/rmw_fastrtps#238>) * Merge pull request #250 <ros2/rmw_fastrtps#250> from ros2/support_static_lib * use namespace_prefix from shared package * Contributors: Dirk Thomas, DongheeYe, William Woodall, ivanpauno . ros-rolling-rmw-fastrtps-cpp (0.6.1-1jammy) jammy; urgency=high . * Add topic cache object for managing topic relations (#236 <ros2/rmw_fastrtps#236>) * Fastrtps 1.7.0 (#233 <ros2/rmw_fastrtps#233>) * RMW_FastRTPS configuration from XML only (#243 <ros2/rmw_fastrtps#243>) * refactor to support init options and context (#237 <ros2/rmw_fastrtps#237>) * Methods to retrieve matched counts on pub/sub (#234 <ros2/rmw_fastrtps#234>) * use uint8_array (#240 <ros2/rmw_fastrtps#240>) * Contributors: Juan Carlos, Karsten Knese, Michael Carroll, MiguelCompany, Ross Desmond, William Woodall . ros-rolling-rmw-fastrtps-cpp (0.6.0-1jammy) jammy; urgency=high . * Add semicolons to all RCLCPP and RCUTILS macros. (#229 <ros2/rmw_fastrtps#229>) * Include node namespaces in get_node_names (#224 <ros2/rmw_fastrtps#224>) * add rmw_get_serialization_format (#215 <ros2/rmw_fastrtps#215>) * Merge pull request #218 <ros2/rmw_fastrtps#218> from ros2/pr203 * Revert "fix template closing indentation (#214 <ros2/rmw_fastrtps#214>)" * fix template closing indentation (#214 <ros2/rmw_fastrtps#214>) * Contributors: Chris Lalancette, Dirk Thomas, Karsten Knese, Michael Carroll, Miguel Company, Mikael Arguedas . ros-rolling-rmw-fastrtps-cpp (0.5.1-1jammy) jammy; urgency=high . * update maintainer * Contributors: Dirk Thomas . ros-rolling-rmw-fastrtps-cpp (0.5.0-1jammy) jammy; urgency=high . * Avoid allocations (#211 <ros2/rmw_fastrtps#211>) * Temporary buffer remove (#207 <ros2/rmw_fastrtps#207>) * Validate the buffer_ of CustomServiceRequest object before using it to (#210 <ros2/rmw_fastrtps#210>) * update usage of rcutils_join_path() (#208 <ros2/rmw_fastrtps#208>) * Expose raw CDR stream for publish and subscribe (#186 <ros2/rmw_fastrtps#186>) * Remove topic partitions (#192 <ros2/rmw_fastrtps#192>) * Fix leak if client reponse is never taken (#201 <ros2/rmw_fastrtps#201>) * Revert "Export rmw_fastrtps_cpp target" (#200 <ros2/rmw_fastrtps#200>) * Support access control (#197 <ros2/rmw_fastrtps#197>) * Export rmw_fastrtps_cpp target (#198 <ros2/rmw_fastrtps#198>) * Fix deserialization segfault in bionic. (#199 <ros2/rmw_fastrtps#199>) * Fix namespaces (#196 <ros2/rmw_fastrtps#196>) * Merge pull request #182 <ros2/rmw_fastrtps#182> from ros2/node_name_in_user_data * add participant listener * add node name to user data * change export order for static linking (#190 <ros2/rmw_fastrtps#190>) * update style (#189 <ros2/rmw_fastrtps#189>) * optimize timeout judgement according to different condition (#187 <ros2/rmw_fastrtps#187>) * use existing check_wait_set_for_data to avoid duplicated code (#185 <ros2/rmw_fastrtps#185>) * Enable logging level manipulation from rmw_fastrtps (#156 <ros2/rmw_fastrtps#156>) * Small performance improvements (#183 <ros2/rmw_fastrtps#183>) * Segmentation error to dereference nullptr (#180 <ros2/rmw_fastrtps#180>) * Contributors: Dirk Thomas, Ethan Gao, Guillaume Autran, Karsten Knese, Michael Carroll, MiguelCompany, Mikael Arguedas, Minggang Wang, Rohit Salem, Shane Loretz, Sriram Raghunathan, William Woodall, jwang11 . ros-rolling-rmw-fastrtps-cpp (0.4.0-1jammy) jammy; urgency=high . * Merge pull request #178 <ros2/rmw_fastrtps#178> from ros2/fix_wrong_count * Merge pull request #177 <ros2/rmw_fastrtps#177> from ros2/rename_group * Wait set two words (#175 <ros2/rmw_fastrtps#175>) * not exporting pthread manually (#174 <ros2/rmw_fastrtps#174>) * Merge pull request #169 <ros2/rmw_fastrtps#169> from ros2/rep149 * Merge pull request #171 <ros2/rmw_fastrtps#171> from jwang11/master * rcutils_join_path returns a char * now. (#173 <ros2/rmw_fastrtps#173>) * memory leak issue (#172 <ros2/rmw_fastrtps#172>) * Unify and simplify de/serializeROSmessage processing * Avoid duplicated code in calculateMaxSerializedSize for array and normal member (#168 <ros2/rmw_fastrtps#168>) * Fix the issues to dereference to nullptr (#165 <ros2/rmw_fastrtps#165>) * Fix rmw_fastrtps dead code (#163 <ros2/rmw_fastrtps#163>) * Merge pull request #167 <ros2/rmw_fastrtps#167> from deng02/tune-count-pub-sub * Remove string allocation in the count of subscribers and publishers * use auto deduction and nullptr to keep coding style consistent (#162 <ros2/rmw_fastrtps#162>) * Merge pull request #164 <ros2/rmw_fastrtps#164> from dejanpan/master * Fix several parameter check issues in rmw_fastrtps_cpp apis * Remove unnecessary dependency on rosidl_generator_cpp (#161 <ros2/rmw_fastrtps#161>) * Move the hasData checks for non-blocking wait 'timeout' higher (#158 <ros2/rmw_fastrtps#158>) * Support loading default XML profile file (#153 <ros2/rmw_fastrtps#153>) * Drop duplicated rmw_init.cpp in rmw_fastrtps_cpp/CMakeLists.txt (#155 <ros2/rmw_fastrtps#155>) * Merge pull request #154 <ros2/rmw_fastrtps#154> from ros2/uncrustify_master * Removing magic numbers: old maximun lengths (#152 <ros2/rmw_fastrtps#152>)

dirk-thomas added the requires-changes label Oct 13, 2017

mikaelarguedas added the in progress Actively being worked on (Kanban column) label Oct 18, 2017

Sriram Raghunathan added 2 commits October 25, 2017 14:08

Rename file from rmw_fastrtps_configure to rmw_logging, which follows…

4393093

… the patterns being used already. like rmw_node, rmw_publisher.. Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

dirk-thomas suggested changes Oct 25, 2017

View reviewed changes

- Fix, coding errors.

82f178b

- Renmae API to suite ros styles Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

dirk-thomas reviewed Oct 26, 2017

View reviewed changes

Sriram Raghunathan added 2 commits October 29, 2017 14:22

Fix ament_cpplint warnings

6c36dac

Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

Merge branch 'master' into sriram_beta3

db2d734

Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>

Merge branch 'master' of https://github.com/ros2/rmw_fastrtps into sr…

5030f85

…iram_beta3

sriramster force-pushed the sriram_beta3 branch from a6d2aba to 5030f85 Compare October 31, 2017 12:35

dirk-thomas reviewed Nov 6, 2017

View reviewed changes

Remove utility function to create a 'error' returnable API for settin…

220b4bc

…g logging Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>

dirk-thomas reviewed Dec 13, 2017

View reviewed changes

Fix, logging msg bug.

c38d5aa

dirk-thomas reviewed Dec 19, 2017

View reviewed changes

Modify logging mapping for type 'debug' from warning to info.

23c8b0f

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>

order log levels, use different local variable name, include unknown …

a01006a

…severity in error message

dirk-thomas approved these changes Dec 19, 2017

View reviewed changes

dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) requires-changes labels Dec 19, 2017

Sriram Raghunathan added 3 commits January 4, 2018 12:23

Merge into master

5a21b3b

Fix error due to parameterized logging

a7bd975

Fix code style issues from uncrustify

a415c52

dirk-thomas merged commit 0149205 into ros2:master Jan 18, 2018

dirk-thomas removed the in review Waiting for review (Kanban column) label Jan 18, 2018

dhood mentioned this pull request Mar 1, 2018

dynamic_bridge problem with unstable listener ros2/ros1_bridge#105

Closed

dirk-thomas mentioned this pull request Aug 29, 2018

Allow configuration of the severity level for eProsima logging #150

Closed

Enable logging level manipulation from rmw_fastrtps #156

Enable logging level manipulation from rmw_fastrtps #156

Conversation

sriramster commented Oct 13, 2017 • edited by dirk-thomas Loading

dirk-thomas commented Oct 13, 2017

sriramster commented Oct 13, 2017

dirk-thomas commented Oct 13, 2017

sriramster commented Oct 13, 2017

dirk-thomas commented Oct 13, 2017

dhood commented Oct 13, 2017

sriramster commented Oct 13, 2017

mikaelarguedas commented Oct 13, 2017 • edited Loading

dirk-thomas commented Oct 13, 2017

sriramster commented Oct 13, 2017

sriramster commented Oct 25, 2017

dirk-thomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sriramster commented Oct 26, 2017

Choose a reason for hiding this comment

dirk-thomas commented Oct 26, 2017

sriramster commented Oct 29, 2017

dirk-thomas commented Oct 30, 2017

sriramster commented Oct 31, 2017

dirk-thomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sriramster commented Nov 19, 2017

sriramster commented Nov 27, 2017

sriramster commented Dec 12, 2017

dirk-thomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sriramster commented Dec 19, 2017

Choose a reason for hiding this comment

sriramster commented Dec 19, 2017

dirk-thomas commented Dec 19, 2017

sriramster commented Dec 26, 2017

sriramster commented Oct 13, 2017 •

edited by dirk-thomas

Loading

mikaelarguedas commented Oct 13, 2017 •

edited

Loading