Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented action bridge #256

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Implemented action bridge #256

wants to merge 43 commits into from

Commits on Mar 27, 2023

  1. added action templates 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    688768b View commit details
    Browse the repository at this point in the history

  2. generate action interface mappings 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5bbc928 View commit details
    Browse the repository at this point in the history

  3. added action factories 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    d4fc03e View commit details
    Browse the repository at this point in the history

  4. added action_bridge executable 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    d833d8c View commit details
    Browse the repository at this point in the history

  5. fix template 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    629697e View commit details
    Browse the repository at this point in the history

  6. hack for GripperCommand 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    1539a30 View commit details
    Browse the repository at this point in the history

  7. Update include/ros1_bridge/action_factory.hpp 

    Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @fujitatomoya
    hsd-dev and fujitatomoya committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5d96c75 View commit details
    Browse the repository at this point in the history

  8. Fix python script errors in action generation 

    Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    Victor Lopez authored and hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    e265f37 View commit details
    Browse the repository at this point in the history

  9. Foxy and later action compatibility 

    Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    Victor Lopez authored and hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    2d51958 View commit details
    Browse the repository at this point in the history

  10. Reorder ros node initialization to allow renaming of bridge 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    Victor Lopez authored and hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    0040380 View commit details
    Browse the repository at this point in the history

  11. fix error during rebase 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    580ad9e View commit details
    Browse the repository at this point in the history

  12. updated deprecated GoalResponseCallback signature 

    https://github.com/ros2/rclcpp/blob/master/rclcpp_action/include/rclcpp_action/client.hpp#L289-L299

Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    33b8bce View commit details
    Browse the repository at this point in the history

  13. Update resource/interface_factories.cpp.em 

    Co-authored-by: Victor Lopez <3469405+v-lopez@users.noreply.github.com>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @v-lopez
    hsd-dev and v-lopez committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    3d8dee1 View commit details
    Browse the repository at this point in the history

  14. applied uncrustify patches 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    1091806 View commit details
    Browse the repository at this point in the history

  15. fix action mapping rules 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    74188ff View commit details
    Browse the repository at this point in the history

  16. print available action pairs 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5cd1321 View commit details
    Browse the repository at this point in the history

  17. get active ROS1 action servers and clients 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    3c3fe17 View commit details
    Browse the repository at this point in the history

  18. remove prints 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    0210c17 View commit details
    Browse the repository at this point in the history

  19. fix mapping rules for services 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    b256b9f View commit details
    Browse the repository at this point in the history

  20. reformatted with uncrustify 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    aafcf3a View commit details
    Browse the repository at this point in the history

  21. map actions in dynamic_bridge 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    9c83a93 View commit details
    Browse the repository at this point in the history

  22. shutdown internal server before removing the bridge 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    bc350f4 View commit details
    Browse the repository at this point in the history

  23. updated GoalResponseCallback signature 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    deb5805 View commit details
    Browse the repository at this point in the history

  24. updated README 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    69c815b View commit details
    Browse the repository at this point in the history

  25. fix formatting 

    added NOLINT whenever both cpplint and uncrustify cannot be satisfied
ament/ament_lint#158

Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    1f600e0 View commit details
    Browse the repository at this point in the history

  26. add actionlib dependency with condition 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    1dd38b3 View commit details
    Browse the repository at this point in the history

  27. added dependency on rclcpp_action 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    a5eb300 View commit details
    Browse the repository at this point in the history

  28. Update CMakeLists.txt 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @gbiggs
    hsd-dev and gbiggs committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    91b3197 View commit details
    Browse the repository at this point in the history

  29. Update README.md 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @gbiggs
    hsd-dev and gbiggs committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    51ac119 View commit details
    Browse the repository at this point in the history

  30. Update include/ros1_bridge/action_factory.hpp 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @gbiggs
    hsd-dev and gbiggs committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    94404b0 View commit details
    Browse the repository at this point in the history

  31. Update resource/get_factory.cpp.em 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @gbiggs
    hsd-dev and gbiggs committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    d7fdc6d View commit details
    Browse the repository at this point in the history

  32. Update ros1_bridge/__init__.py 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @gbiggs
    hsd-dev and gbiggs committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    c071edf View commit details
    Browse the repository at this point in the history

  33. Update src/action_bridge.cpp 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev @gbiggs
    hsd-dev and gbiggs committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    be56382 View commit details
    Browse the repository at this point in the history

  34. risk leaking if the reset call crashes somehow 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    94b9c70 View commit details
    Browse the repository at this point in the history

  35. Add goal ID to log output so it's more useful 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    21bee28 View commit details
    Browse the repository at this point in the history

  36. rename variable so it's distinction from the variable with the same n… 

    …ame in the enclosing class

Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7ba2784 View commit details
    Browse the repository at this point in the history

  37. Change cout to use RCLCPP logging macros. 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    084ed7f View commit details
    Browse the repository at this point in the history

  38. remove commented out code 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    86a8140 View commit details
    Browse the repository at this point in the history

  39. fix parenthesis 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    12838b9 View commit details
    Browse the repository at this point in the history

  40. remove unused params 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    6b10de4 View commit details
    Browse the repository at this point in the history

  41. fix nullptr keyword 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    514f53d View commit details
    Browse the repository at this point in the history

  42. remove outdated comments 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5e3c841 View commit details
    Browse the repository at this point in the history

  43. pass logger to GoalHandler 

    Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
    @hsd-dev
    hsd-dev committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    79a46de View commit details
    Browse the repository at this point in the history