Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .msg/.srv files to be in subdirectories of msg/, srv/ #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janstrohbeck
Copy link

If one has the following ROS1 message layout:

msg/
  group1/
    MessageDefinition1.msg
    MessageDefinition2.msg
  group2/
    MessageDefinition3.msg

That is, the .msg files are not directly in the msg folder, but in subfolders. Then the bridge does not find the message files correctly. The same goes for files in subfolders in the srv directory. This PR expands the search for .msg and .srv files to subdirectories, to make it work.

Signed-off-by: Jan Strohbeck <jan.strohbeck@uni-ulm.de>
@janstrohbeck janstrohbeck force-pushed the allow_message_subdirectories branch from fbe169a to 7c72fc7 Compare August 26, 2021 11:25
@gbiggs
Copy link
Member

gbiggs commented Feb 4, 2022

@janstrohbeck You wouldn't happen to have a test of a minimal reproducible example I can use to verify this works, would you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants