The service name might provide more debug information than host:port details #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…details Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Timple
force-pushed
the
add-name-to-print
branch
from
1640af5 to
868388d
Compare
fujitatomoya
requested changes
Mar 7, 2022
|
@Timple could you address DCO failure https://github.com/ros2/ros1_bridge/pull/346/checks?check_run_id=5453577906? |
fujitatomoya
approved these changes
Mar 7, 2022
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Timple
force-pushed
the
add-name-to-print
branch
from
beb4958 to
7845a57
Compare
gbiggs
approved these changes
Mar 7, 2022
clalancette
approved these changes
Mar 22, 2022
gbiggs
added a commit
that referenced
this pull request
Mar 24, 2022
* Reformatted README.md This is an initial cleanup attempt of the README.md file. All non-code lines have been wrapped to an 80 column width, and some markdown was cleaned up. Further work is needed. Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Added 'bash' info string to appropriate fenced code blocks. Numerous fenced code blocks did not have a [info string](https://github.github.com/gfm/#info-string), which meant that the enclosed code block wouldn't be rendered correctly. As it turned out, all of these were intended to be run in a bash shell, so I added that as their info strings. Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * WIP: Updated the scripts in the README.md file to use environment variables. The scripts weren't directly executable before, requiring manual substitution of various 'variables'. This was unfortunate as Github makes copying and pasting code blocks simple and straightforward. The changes in this commit make it possible to copy/paste each example into it's own shell, which should make it slightly easier for new users to start using the bridge. Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * fix: Unwrapped lines per request from @gbiggs. @gbiggs commented at #342 (comment) that files in ROS2 are intentionally not wrapped to make handling diffs in PRs easier. I've copied in the relevant original lines to unwrap the lines I wrapped earlier. Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Accepted suggestion from @gbiggs Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * Update README.md Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * The service name might provide more debug information than host:port details (#346) * The service name might provide more debug information than host:port details Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> * fix: Changed 'galactic' to 'rolling' Changes due to suggestions from @gbiggs in the discussion of [PR 342](#342 (comment)) Signed-off-by: Cem Karan <cem.f.karan.civ@army.mil> Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.