Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iron] Clarification on "setup bag" in ROS 2 Iron Tutorial #4048

Closed
songyuc opened this issue Dec 4, 2023 · 10 comments
Closed

[Iron] Clarification on "setup bag" in ROS 2 Iron Tutorial #4048

songyuc opened this issue Dec 4, 2023 · 10 comments

Comments

@songyuc
Copy link
Contributor

songyuc commented Dec 4, 2023

Hi, guys,

I am currently going through the ROS 2 Iron documentation and came across a reference to a "setup bag" in the Reading from a bag file (C++) tutorial. The tutorial mentions running a script with the path to this setup bag, but I am unsure what this bag file refers to or where it is created.

Could you please provide some clarification on what the setup bag is and in which part of the ROS 2 tutorials it is created or introduced? This information would be greatly helpful for understanding the context and completing the tutorial effectively.

Thank you for your assistance and for the valuable resources provided in the ROS 2 documentation.

Best regards,
Yucheng Song

@iuhilnehc-ynos
Copy link

image

@songyuc
Copy link
Contributor Author

songyuc commented Dec 4, 2023

Hi, @iuhilnehc-ynos,

Thank you for your response to my query regarding the "setup bag" mentioned in the "Reading from a bag file (C++)" tutorial. I have reviewed the "Recording a bag from a node (C++)" tutorial as you suggested, and I found it to be very informative on the process of recording data to a bag file using a custom C++ node. The tutorial details creating a new package, writing the C++ node, and running the node to record to a bag file named "my_bag".

However, I did not find any reference to a "setup bag" in this tutorial. The term "setup bag" was not explicitly defined or used in the context of the tutorial, and it appears that the "Recording a bag from a node (C++)" tutorial focuses on working with a newly created bag file rather than using an existing "setup bag".

Could you please provide further clarification on what the "setup bag" refers to? Is it a term from a different tutorial or a commonly used bag file in the ROS community that I might have missed?

I appreciate your time and assistance as I navigate through the ROS 2 documentation.

Best regards,
Yucheng Song

@iuhilnehc-ynos
Copy link

iuhilnehc-ynos commented Dec 4, 2023

The bag file can be generated by code or ros2 bag record, if you want the bag file that can be directly used in the Reading from a bag file (C++), I suggest seeing https://docs.ros.org/en/rolling/Tutorials/Beginner-CLI-Tools.html, especially https://docs.ros.org/en/rolling/Tutorials/Beginner-CLI-Tools/Recording-And-Playing-Back-Data/Recording-And-Playing-Back-Data.html#record-multiple-topics . As the section is located before Advanced, I don't think it's necessary to update the doc.

@songyuc
Copy link
Contributor Author

songyuc commented Dec 4, 2023

I guess, "setup bag" actually refers to "subset bag", am I right?

@iuhilnehc-ynos
Copy link

'subset' is the file name in https://docs.ros.org/en/rolling/Tutorials/Beginner-CLI-Tools/Recording-And-Playing-Back-Data/Recording-And-Playing-Back-Data.html#record-multiple-topics.

@songyuc
Copy link
Contributor Author

songyuc commented Dec 4, 2023

I am just a little confused about why "subset bag" is called "setup bag". (Please excuse me if you feel this is a silly question)

@iuhilnehc-ynos
Copy link

I am checking why it it named from subset to setup.

@iuhilnehc-ynos
Copy link

I think it's a typo as it's metioned at the beginning.

image

Can you create a PR to fix it?

@songyuc
Copy link
Contributor Author

songyuc commented Dec 4, 2023

Yes, I can. Please give me some time to do it.

@fujitatomoya
Copy link
Collaborator

@songyuc thank you for the contribution. i will go ahead to close this, #4050 has been merged and humble / iron backports also done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants