Replace setup bag with subset bag in rolling #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @fujitatomoya, I want to let you know that I have made the suggested changes, and would greatly appreciate it if you could take another look at the new pull request and provide any further feedback or approval as needed. Thank you for your time and guidance on this matter. |
|
@Mergifyio backport to iron and humble |
❌ No backport have been created
GitHub error:
GitHub error:
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit f4fd8dd)
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit f4fd8dd)
fujitatomoya
pushed a commit
that referenced
this pull request
Dec 5, 2023
fujitatomoya
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a typographical error found in the ROS 2 Iron documentation, specifically in the "Reading from a bag file (C++)" tutorial. The tutorial erroneously references a "
setupbag" when it should actually be "subset bag". This confusion was discussed and clarified in Issue #4048.The correction ensures that the documentation accurately reflects the content of the tutorials, particularly where it guides users in generating and using bag files in ROS 2.