Update Setup-ROS-2-with-VSCode-and-Docker-Container.rst #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosdep needs to be installed. Signed-off-by: Z223I <31394498+Z223I@users.noreply.github.com>
clalancette
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Technically, this guide doesn't actually require rosdep. However, I can definitely see that this would be much more convenient. I'm fine with this; @fujitatomoya what do you think?
fujitatomoya
reviewed
Dec 2, 2024
| @@ -182,6 +182,8 @@ Open the Dockerfile and add the following contents: | |||
| && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ | |||
| && chmod 0440 /etc/sudoers.d/$USERNAME | |||
| RUN apt-get update && apt-get upgrade -y | |||
| RUN apt-get update && apt-get install -y python3-rosdep \ | |||
There was a problem hiding this comment.
why we need to install python3-rosdep again? base image already has that.
| @@ -182,6 +182,8 @@ Open the Dockerfile and add the following contents: | |||
| && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ | |||
| && chmod 0440 /etc/sudoers.d/$USERNAME | |||
| RUN apt-get update && apt-get upgrade -y | |||
| RUN apt-get update && apt-get install -y python3-rosdep \ | |||
| && rosdep init && rosdep update | |||
There was a problem hiding this comment.
i believe we should not do this in container image creation, because this generates the dependency how to bind the file system to the development environment. that is why we have done this in devcontainer.json in postCreateCommand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosdep needs to be installed.