Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Setup-ROS-2-with-VSCode-and-Docker-Container.rst #4880

Open
wants to merge 1 commit into
base: jazzy
Choose a base branch
from
Open

Update Setup-ROS-2-with-VSCode-and-Docker-Container.rst #4880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ Open the Dockerfile and add the following contents:
&& echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
&& chmod 0440 /etc/sudoers.d/$USERNAME
RUN apt-get update && apt-get upgrade -y
RUN apt-get update && apt-get install -y python3-rosdep \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to install python3-rosdep again? base image already has that.

&& rosdep init && rosdep update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe we should not do this in container image creation, because this generates the dependency how to bind the file system to the development environment. that is why we have done this in devcontainer.json in postCreateCommand.

RUN apt-get install -y python3-pip
ENV SHELL /bin/bash

Expand Down