Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explanation about component containers. #4902

Merged
merged 1 commit into from
Dec 26, 2024
Merged

add explanation about component containers. #4902

merged 1 commit into from
Dec 26, 2024

Conversation

fujitatomoya
Copy link
Collaborator

closes #4901

@fujitatomoya
Copy link
Collaborator Author

@christophebedard @clalancette can you take a look? thanks in advance.

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-component-container branch from 94bf175 to 965d922 Compare December 13, 2024 23:47
@fujitatomoya fujitatomoya requested review from christophebedard and clalancette and removed request for clalancette December 13, 2024 23:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12507688481/artifacts/2364113459.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4902/index.html in your favorite browser

fujitatomoya
fujitatomoya commented Dec 13, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can follow up once ros2/rclcpp#2541 is merged.

source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
christophebedard
christophebedard reviewed Dec 18, 2024
View reviewed changes
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Concepts/Intermediate/About-Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Show resolved Hide resolved
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-component-container branch from 2839672 to f3aad80 Compare December 19, 2024 02:24
@fujitatomoya
Copy link
Collaborator Author

@christophebedard thanks for doing review on this, most of your comments are addressed by f3aad80

just fyi, since i borrowed most of your suggestions, that put you as Co-Author.

@fujitatomoya
Copy link
Collaborator Author

@christophebedard thanks for checking on this, all comments are addressed. requesting review once again.

@fujitatomoya @christophebedard
add explanation about component containers.
e1cc880 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-component-container branch from 4ea79f7 to e1cc880 Compare December 26, 2024 19:35
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Dec 26, 2024 •
edited
Loading

@christophebedard all comments are resolved, and i cleaned up the commit history and messages with squash.

christophebedard
christophebedard approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating 😁

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Dec 26, 2024
@clalancette clalancette merged commit 994c0d9 into rolling Dec 26, 2024
4 checks passed
@clalancette clalancette deleted the fujitatomoya/add-component-container branch December 26, 2024 19:54
mergify bot pushed a commit that referenced this pull request Dec 26, 2024
@fujitatomoya @mergify
add explanation about component containers. (#4902)
e1611c5 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
(cherry picked from commit 994c0d9)
@mergify mergify bot mentioned this pull request Dec 26, 2024
Merged
mergify bot pushed a commit that referenced this pull request Dec 26, 2024
@fujitatomoya @mergify
add explanation about component containers. (#4902)
ffc92fe 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
(cherry picked from commit 994c0d9)
@mergify mergify bot mentioned this pull request Dec 26, 2024
Merged
clalancette pushed a commit that referenced this pull request Dec 26, 2024
@mergify @fujitatomoya
add explanation about component containers. (#4902) (#4918)
2b77176 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
(cherry picked from commit 994c0d9)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Dec 26, 2024
@mergify @fujitatomoya
add explanation about component containers. (#4902) (#4919)
da9b830 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
(cherry picked from commit 994c0d9)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette @christophebedard thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add explanation about component container types and options
3 participants
@fujitatomoya @clalancette @christophebedard