Make converter_factory_ private

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
ros2 · Apr 14, 2020 · f2fea42 · f2fea42
1 parent 8a7ce11
commit f2fea42
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/rosbag2_cpp/include/rosbag2_cpp/readers/sequential_reader.hpp b/rosbag2_cpp/include/rosbag2_cpp/readers/sequential_reader.hpp
@@ -126,13 +126,15 @@ class ROSBAG2_CPP_PUBLIC SequentialReader
  const std::string & storage_serialization_format);
 
  std::unique_ptr<rosbag2_storage::StorageFactoryInterface> storage_factory_{};
- std::shared_ptr<SerializationFormatConverterFactoryInterface> converter_factory_{};
  std::shared_ptr<rosbag2_storage::storage_interfaces::ReadOnlyInterface> storage_{};
  std::unique_ptr<Converter> converter_{};
  std::unique_ptr<rosbag2_storage::MetadataIo> metadata_io_{};
  rosbag2_storage::BagMetadata metadata_{};
  std::vector<std::string> file_paths_{}; // List of database files.
  std::vector<std::string>::iterator current_file_iterator_{}; // Index of file to read from
+
+private:
+ std::shared_ptr<SerializationFormatConverterFactoryInterface> converter_factory_{};
 };
 
 } // namespace readers

diff --git a/rosbag2_cpp/src/rosbag2_cpp/readers/sequential_reader.cpp b/rosbag2_cpp/src/rosbag2_cpp/readers/sequential_reader.cpp
@@ -61,9 +61,9 @@ SequentialReader::SequentialReader(
  std::shared_ptr<SerializationFormatConverterFactoryInterface> converter_factory,
  std::unique_ptr<rosbag2_storage::MetadataIo> metadata_io)
 : storage_factory_(std::move(storage_factory)),
- converter_factory_(std::move(converter_factory)),
  converter_(nullptr),
- metadata_io_(std::move(metadata_io))
+ metadata_io_(std::move(metadata_io)),
+ converter_factory_(std::move(converter_factory))
 {}
 
 SequentialReader::~SequentialReader()