use fastrtps static instead of dynamic #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Merged
|
The CI builds are showing a few test failures? |
|
Yes, I have to look into these. Mainly the end-to-end tests are difficult because not always all messages are received. |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
In order to push forward, I disabled the flaky test and increased time for discovery for the other failing test.
|
|
Putting this back in review. Increasing waiting time for discovery seemed to have solved the flaky test. The failures on aarch64 seem unrelated. |
Yeah, those are known flaky, so you can safely ignore them for now. |
dirk-thomas
approved these changes
May 2, 2019
This was referenced May 2, 2019
Merged
|
Merging this, having the follow up work to re-enable the tests ticketed in #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the CI for integrating rosbag2 into the
ros2.repos.The CI is using the default setup with having
Connext staticandFastrtps staticenabled:Connected PR for repos file:
Signed-off-by: Karsten Knese karsten@openrobotics.org