-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes to enable searching for .msg files in sub-directories #1218
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: aditya <aditya@nimble.ai>
Signed-off-by: aditya <aditya@nimble.ai>
Signed-off-by: aditya <aditya@nimble.ai>
Failure in this test seems unrelated to the change in this PR |
Are you able to add a test for this new behavior? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include some equivalent of this patch to prevent the message definition cache mistaking CompressedImage.msg
for Image.msg
. Also, please add a test to this repo to ensure that this behavior is correct going forward.
Signed-off-by: aditya <aditya@nimble.ai>
Patch has been added. Is there any relevant documentation to compile and run tests in this repo? Or should I follow the normal |
|
This reverts commit 548c64f.
Fix for #1188