Add windows to build matrix

[piraka9011]

Add Windows to the build and test workflow.

Closes #316

Signed-off-by: Anas Abou Allaban aabouallaban@pm.me

[piraka9011]

Windows build failing since there's a double repo pull somewhere:

colcon ERROR colcon build: Duplicate package names not supported:
- ros2bag:
    - d:\a\rosbag2\rosbag2\ros_ws\src\ros2\rosbag2\ros2bag
    - d:\a\rosbag2\rosbag2\ros_ws\src\rosbag2\ros2bag

It looks like this requires a custom ros2.repos file.

[zmichaels11]

Windows build failing since there's a double repo pull somewhere:

colcon ERROR colcon build: Duplicate package names not supported:
- ros2bag:
    - d:\a\rosbag2\rosbag2\ros_ws\src\ros2\rosbag2\ros2bag
    - d:\a\rosbag2\rosbag2\ros_ws\src\rosbag2\ros2bag

It looks like this requires a custom ros2.repos file.

That looks like it pulled in rosbag2 from the master ros2.repos file. Is this a bug in the action-ros-ci? I would think that it should filter out the current repo if it is found within the repos file.

Edit:
I looked into this a little more, action-ros-ci is functioning correctly; filtering out repos from the repos file should be out-of-scope for action-ros-ci. I think the proper long-term solution would be to create a step (maybe GitHub Action?) within the workflow that generates the ros2.repos file.

[piraka9011]

@zmichaels11 we can use the workflow suggested in the action itself here :)

# Run the generator and output the results to a file.
- run: |
    rosinstall_generator <package-name> --rosdistro <target-distro> \
    --deps-only --deps --upstream-development > /tmp/deps.repos

Also the repos pull failed b/c the repo is not checked out with the checkout action.

[Karsten1987]

That'd be fantastic to have Windows github actions. We've recently switched over the ros2 ci to windows container builds. Maybe that's some point of interest to help debugging this problem?

[thomas-moulard]

https://github.com/ros-tooling/action-ros-ci/blob/master/src/action-ros-ci.ts#L145-L154 @piraka9011 PTAL

[piraka9011]

The first issue was resolved but then this issue popped up again :) ros-tooling/action-ros-ci#79
Will re-open once a resolution is found.