Move qos utilities to their own compilation unit #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #125
Moves the adaptive QoS logic into the QoS compilation unit and adds explicit unit tests for it.
This removes this qos-specific knowledge from Recorder (and upcoming Player). Eventually an even more generic version of this should make it into rclcpp, possibly as part of the
GenericPublisher
/GenericSubscription
push - adaptive QoS is a necessary part of a generic transport in ROS 2Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com