Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Expose the MessageInfo to the GenericSubscription to potentially use to match messages to QoS #633

Closed
wants to merge 1 commit into from

Conversation

emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Feb 4, 2021

Experiment for #629 to see how hard it is to receive message metadata to potentially correlate incoming messages with a specific publisher. Looks very promising

Briefly tested, 2 publishers on /foo, and one on /bar - the print statement in the message callback gives output like:

$ ros2 bag record -a -o bagSeesMessageInfo
[INFO] [1612406764.918839725] [rosbag2_storage]: Opened database 'bagSeesMessageInfo/bagSeesMessageInfo_0.db3' for READ_WRITE.
[INFO] [1612406764.926742967] [rosbag2_transport]: Listening for topics...
[INFO] [1612406764.928994114] [rosbag2_transport]: Subscribed to topic '/rosout'
[INFO] [1612406764.930462463] [rosbag2_transport]: Subscribed to topic '/foo'
[INFO] [1612406764.932862746] [rosbag2_transport]: Subscribed to topic '/parameter_events'
[INFO] [1612406764.934140601] [rosbag2_transport]: Subscribed to topic '/bar'
[INFO] [1612406765.247710249] [rosbag2_transport]: MESSAGE INFO on /bar: pubgid !$g
[INFO] [1612406765.322675283] [rosbag2_transport]: MESSAGE INFO on /foo: pubgid NrE[0m
[INFO] [1612406765.504592903] [rosbag2_transport]: MESSAGE INFO on /foo: pubgid ^b
[INFO] [1612406766.247643351] [rosbag2_transport]: MESSAGE INFO on /bar: pubgid !$g
[INFO] [1612406766.322676287] [rosbag2_transport]: MESSAGE INFO on /foo: pubgid NrE[0m
[INFO] [1612406766.504602200] [rosbag2_transport]: MESSAGE INFO on /foo: pubgid ^b
[INFO] [1612406767.247675681] [rosbag2_transport]: MESSAGE INFO on /bar: pubgid !$g
[INFO] [1612406767.322470858] [rosbag2_transport]: MESSAGE INFO on /foo: pubgid NrE[0m

…to match messages to QoS

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp deleted the emersonknapp/subscription_message_info branch March 25, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant