Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pause/resume options to the bag recorder #905

Merged
merged 10 commits into from
Nov 24, 2021
Merged

Add pause/resume options to the bag recorder #905

merged 10 commits into from
Nov 24, 2021

Commits on Nov 5, 2021

  1. Add pause/resume options to the bag recorder 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    bfa7f2b View commit details
    Browse the repository at this point in the history

  2. fix linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    c8e3ff3 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. toogle -> toggle 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    6754536 View commit details
    Browse the repository at this point in the history

  2. Avoid installing KeyboardHandler callback multiple times 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    05e55e3 View commit details
    Browse the repository at this point in the history

  3. Use an atomic<bool> instead of an atomic<int> 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    7287b45 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Use constant instead of extending RecordOptions to specify the pause/… 

    …resume toggle key

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    1f404b9 View commit details
    Browse the repository at this point in the history

  2. Add constructor to Recorder() allowing to mock the KeyboardHandler 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    a1a1d4a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Add recorder keyboard control test 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 11, 2021
    4 Configuration menu
    Copy the full SHA
    b6c35a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. remove comment 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    bca8e74 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Add ros2 bag record --start-paused test 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    b11614f View commit details
    Browse the repository at this point in the history