Remove YAML_CPP_DLL define

[Ace314159]

Since ros2/yaml_cpp_vendor#10 is fixed, the explicit YAML_CPP_DLL define is no longer needed and needs to be removed to prevent the macro redefinition warnings.

This should be backported to foxy and galactic.

[gbiggs]

CI:

• Linux
• Linux-aarch64
• Windows

[Ace314159]

Perhaps ros2/yaml_cpp_vendor#10 wasn't fixed? It's interesting that ros-perception/image_common#231 seems to be fine though.

[gbiggs]

Have you successfully built it on Windows locally?

[jacobperron]

With respect to how yaml_cpp_vendor is being linked against, the only difference I can spot between rosbag2_storage and the other two packages in rviz and image_common is that the other two package specify the link dependency as PUBLIC (for example). Maybe we could try doing the same here:

rosbag2/rosbag2_storage/CMakeLists.txt

Lines 42 to 47 in cc0e039

	ament_target_dependencies(
	${PROJECT_NAME}
	pluginlib
	rcpputils
	rcutils
	yaml_cpp_vendor)

I don't know if this will fix the build failure here, but it might fix a loosely related issue downstream: https://build.ros2.org/view/Rbin_rhel_el864/job/Rbin_rhel_el864__domain_bridge__rhel_8_x86_64__binary/107/consoleFull

23:06:51 DEBUG: /usr/bin/ld: warning: libyaml-cpp.so.0.7, needed by /opt/ros/rolling/lib/librosbag2_cpp.so, not found (try using -rpath or -rpath-link)
23:06:51 DEBUG: /opt/ros/rolling/lib/librosbag2_storage.so: undefined reference to `YAML::detail::node_data::empty_scalar[abi:cxx11]()'
23:06:51 DEBUG: /opt/ros/rolling/lib/librosbag2_storage.so: undefined reference to `YAML::detail::node_data::convert_to_map(std::shared_ptr<YAML::detail::memory_holder> const&)'
23:06:51 DEBUG: /opt/ros/rolling/lib/librosbag2_storage.so: undefined reference to `YAML::detail::node::m_amount'
23:06:51 DEBUG: /opt/ros/rolling/lib/librosbag2_storage.so: undefined reference to `YAML::detail::node_data::push_back(YAML::detail::node&, std::shared_ptr<YAML::detail::memory_holder> const&)'

[jacobperron]

Nevermind, rviz is also failing to build: https://ci.ros2.org/job/ci_windows/16574

[Ace314159]

What did yaml-cpp 0.7.0 add from previous versions to provide the YAML_CPP_DLL define? I was looking at the source, and I wasn't able to find anything.

I don't think the linking needs to be changed since the galactic and foxy fixes for yaml_cpp_vendor have the macro redefinition warnings without any changes here.

[Ace314159]

Should we try applying the change from ros2/yaml_cpp_vendor#31 to the main branch of yaml_cpp_vendor since we know that change does define YAML_CPP_DLL

[jacobperron]

I've ported the yaml_cpp_vendor change to export YAML_CPP_DLL to Rolling (ros2/yaml_cpp_vendor#38) and triggered CI, but there's still an issue with rosbag2_storage:

• Windows

[emersonknapp]

LGTM with green CI

[Ace314159]

@jacobperron I've identified the cause of the build failure. I've suggested a fix on the yaml_cpp_vendor PR.

[jacobperron]

CI:

• Linux
• Linux-aarch64
• Windows