Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galactic backport of #648 and #650 #668

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Galactic backport of #648 and #650 #668

merged 4 commits into from
Apr 25, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Mar 8, 2022

This is helpful for the ros2_rust project.

I also backported the equality functions, since without them there were merge conflicts.

hidmic and others added 3 commits March 8, 2022 21:49
@hidmic @nnmm
Implement equality operator function for C messages. (ros2#648)
7ec2c40 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @nnmm
Implement copy function for C messages (ros2#650)
13ab6c3 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@nnmm
Replace rcutils_allocator with the system allocator
e011f84 
Signed-off-by: Nikolai Morin <nnmmgit@gmail.com>
@nnmm
Copy link
Contributor Author

nnmm commented Mar 8, 2022

@hidmic Could you review?

@nnmm
Set the output size unconditionally when copying sequences
258b9ca 
Signed-off-by: Nikolai Morin <nnmmgit@gmail.com>
hidmic
hidmic approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galactic CI up to rosidl_generator_c and rosidl_runtime_c:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@nnmm
Copy link
Contributor Author

nnmm commented Apr 22, 2022

@hidmic Thank you for approving! Unfortunately I don't have write permissions, could you also merge this (and #667)?

@hidmic hidmic merged commit e9eea15 into ros2:galactic Apr 25, 2022
@nnmm
Copy link
Contributor Author

nnmm commented Apr 25, 2022

Thx! 🙏

@nnmm nnmm deleted the galactic_backport_648_and_650 branch April 25, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnmm @hidmic