Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect rosidl_target_interfaces from using NOTFOUND in include_directories #679

Merged
merged 1 commit into from
May 10, 2022

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented May 5, 2022

Follow up from problems described in ros2/performance_test#39

Testing up to rclcpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

…tories

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero force-pushed the jrivero/safe_ign_cmake_target_interface branch from 7503f07 to 2a18cfc Compare May 5, 2022 22:45
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the same test_graph failure in the last windows repeated job, but I can't imagine how this PR would have caused it. Assuming it's a flaky test, this LGTM.

@j-rivero j-rivero merged commit 7a362b4 into master May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the jrivero/safe_ign_cmake_target_interface branch May 10, 2022 15:40
j-rivero added a commit that referenced this pull request May 10, 2022
…tories (#679)

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Blast545 pushed a commit that referenced this pull request Jun 6, 2022
…tories (#679) (#681)

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants