Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect rosidl_target_interfaces from using NOTFOUND in include_directories (Humble) #681

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Protect rosidl_target_interfaces from using NOTFOUND in include_directories (Humble) #681

merged 1 commit into from
Jun 6, 2022

Conversation

j-rivero
Copy link
Contributor

Backport of #679 for Humble

@j-rivero
Protect rosidl_target_interfaces from using NOTFOUND in include_direc…
2ea93fe 
…tories (#679)

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from Blast545 May 10, 2022 17:29
Blast545
Blast545 approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blast545
Copy link
Contributor

Full Humble CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

Rebuild of CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@Blast545
Copy link
Contributor

Blast545 commented Jun 2, 2022 •
edited
Loading

Windows had flaky SEH: exception failures. Re building Windows:
Build Status -> Windows fatal exception on test_launch_ros, otherwise all tests passed

@Blast545
Copy link
Contributor

Blast545 commented Jun 3, 2022

Re building to avoid merging with red windows.

Windows: Build Status

@Blast545
Copy link
Contributor

Blast545 commented Jun 6, 2022

Green CI + reviewer, merging.

@Blast545 Blast545 merged commit dbb005a into humble Jun 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the jrivero/backport_679 branch June 6, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

Assignees

@Blast545 Blast545

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @Blast545 @clalancette