-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added rosidl_runtime c depencency #58
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
I simple change of name from generator to runtime is easy to understand. But when you add / remove dependencies please describe why you do it. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
rosidl_typesupport_c
Also For example:
rosidl_typesupport_cppReplaced here the right dependencies here: rosidl_runtime_c is only need it, because there is no rosidl_runtime_cpp header used here But we should build_export_depend rosidl_runtime_cpp because them it will be used by message packages |
…encies Signed-off-by: ahcorde <ahcorde@gmail.com>
Last change refer to ros2/rosidl_python#100 (comment) |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
In MacOS
Windows
|
This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443
Signed-off-by: ahcorde ahcorde@gmail.com