Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rosidl_runtime c depencency #58

Merged
merged 9 commits into from
Apr 10, 2020
Merged

added rosidl_runtime c depencency #58

merged 9 commits into from
Apr 10, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 4, 2020

This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@dirk-thomas
Copy link
Member

I simple change of name from generator to runtime is easy to understand. But when you add / remove dependencies please describe why you do it.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…encies

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 1, 2020

Last change refer to ros2/rosidl_python#100 (comment)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 10, 2020

  • Updated all repos involved in this change.
  • Skipping ros1_bridge, qt_*, rqt_*, and rviz_* packages.
  • Testing against test_rclcpp and rosbag2_tests.
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • One warning made the builds unstable but there is a (PR pending)
CMake Deprecation Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_export_interfaces/share/ament_cmake_export_interfaces/cmake/ament_export_interfaces.cmake:37 (message):
ament_export_interfaces() is deprecated, use ament_export_targets() instead
Call Stack (most recent call first):
CMakeLists.txt:85 (ament_export_interfaces)

In MacOS

  • projectroot.cppcheck

Windows

  • some failures in test_rclcpp

@ahcorde ahcorde merged commit e0be055 into master Apr 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rosidl_runtime branch April 10, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants