Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Replaced rosidl_generator_x for rosidl_runtime_x #49

Merged
merged 7 commits into from
Apr 10, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 24, 2020

This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443

rosidl_typesupport_connext is using rosidl_generator_c headers which are located here: rosidl_runtime_c

These packages generate some files which contain some of the headers:

rosidl_typesupport_connext_c

rosidl_typesupport_connext_cpp

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
…xported

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 10, 2020

  • Updated all repos involved in this change.
  • Skipping ros1_bridge, qt_*, rqt_*, and rviz_* packages.
  • Testing against test_rclcpp and rosbag2_tests.
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • One warning made the builds unstable but there is a (PR pending)
CMake Deprecation Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_export_interfaces/share/ament_cmake_export_interfaces/cmake/ament_export_interfaces.cmake:37 (message):
ament_export_interfaces() is deprecated, use ament_export_targets() instead
Call Stack (most recent call first):
CMakeLists.txt:85 (ament_export_interfaces)

In MacOS

  • projectroot.cppcheck

Windows

  • some failures in test_rclcpp

@ahcorde ahcorde merged commit f1320ed into ros2:master Apr 10, 2020
jacobperron added a commit that referenced this pull request Apr 24, 2020
This dependency was accidentally removed in #49.
We have a dependency on a specific version since required behvavior changed in #41.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Apr 24, 2020
This dependency was accidentally removed in #49.
We have a dependency on a specific version since required behvavior changed in #41.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Apr 25, 2020
This dependency was accidentally removed in #49.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants