fix size calculation for WStrings #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
dirk-thomas
force-pushed
the
dirk-thomas/fix-size-calc-wstring
branch
3 times, most recently
from
da93715 to
b14b895
Compare
sloretz
referenced
this pull request
May 4, 2019
* add WString support Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * fix type of string literal Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * check wstring_to_u16_string function Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * fix style Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * fix dll linkage warnings Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
changed the title
dirk-thomas
added
in review
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/fix-size-calc-wstring
branch
from
032fde8 to
12195c0
Compare
|
And finally in review:
|
Karsten1987
approved these changes
May 4, 2019
There was a problem hiding this comment.
lgtm, with green CI.
I have also triggered another rosbag2 build which makes uses of this function to verify this change.
ros2/rosbag2#111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to fix the
rosbag2test_cdr_convertertest...While ROS uses 2 bytes for a U16String FastRTPS operates on
wstrings and therefore we need to count each character with sizeof(wchar_t)` bytes (instead of 2).