Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation against master #111

Merged
merged 8 commits into from
May 7, 2019
Merged

fix compilation against master #111

merged 8 commits into from
May 7, 2019

Conversation

dirk-thomas
Copy link
Member

Fixes #106.

@dirk-thomas dirk-thomas added bug Something isn't working in progress labels May 3, 2019
@Karsten1987
Copy link
Collaborator

I've updated the default converter plugin, however the generic conversion to and from test_msgs::msg::WString currently fail. Don't know how exactly, but I believe serialization within Fast-RTPS might be different with WString.

@Karsten1987
Copy link
Collaborator

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Collaborator

So the test failures are expected (WString). The WIndows build has the same test failures, but by looking at the console output, the build was marked as failure because of a Jenkins error not because of rosbag2.

dirk-thomas and others added 6 commits May 3, 2019 17:34
@dirk-thomas @Karsten1987
use refactored test messages
ce88f59 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas @Karsten1987
partial update
5a387e3 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@Karsten1987
fix rsbag2_converter_default_plugins
71339df 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
fix rosbag2_transport
28cbee0 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
fix rosbag2_tests
f9f64fe 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
add wstring to introspection message
aaf58a6 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 force-pushed the dirk-thomas/fix-compilation-against-master branch from de007c2 to aaf58a6 Compare May 4, 2019 00:40
@Karsten1987
Copy link
Collaborator

new round of CI (test-args: packages-select-regex rosbag2):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

requires ros2/rosidl_typesupport_fastrtps#23

@Karsten1987
default initialize qos profile
ff9e54b 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 mentioned this pull request May 6, 2019
Merged
@Karsten1987
Copy link
Collaborator

Karsten1987 commented May 6, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
avoid deprecated publish signature
b9fc170 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
Copy link
Collaborator

Karsten1987 commented May 7, 2019 •
edited
Loading

new round of CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

needs ros2/rosidl_typesupport_fastrtps#25

@dirk-thomas
Copy link
Member Author

👍 - can't approve my own PR though.

@dirk-thomas dirk-thomas changed the title [WIP] fix compilation against master fix compilation against master May 7, 2019
@Karsten1987 Karsten1987 merged commit 0fcb2e4 into master May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-compilation-against-master branch May 7, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Fails on ROS2 Master
3 participants
@dirk-thomas @Karsten1987 @sloretz