Fix sros2 tests on Windows Debug.

[clalancette]

From what I can tell, it looks like lxml has a bug where it doesn't properly track references to objects via the find() method. This manifests on Windows debug as a crash after we have stopped using the object, but I believe that by that point the underlying memory has already been freed. Windows Debug in particular is sensitive to this.

Fix it by doing a deepcopy of the object returned from the find(). This code isn't performance sensitive, so it shouldn't be a big deal to do it here, and it fixes the bug in my testing.

[mikaelarguedas]

Thanks 🙏

Ideally I'd like to keep separate the behavioral fix and API/signature change to streamline fix back porting to older distros.
Regarding the mutable defaults 👍 (hence the frecebtly added file), however what would you think about making all ARGS keyed-args and keeping the order as is ?

Finally is it possible to trigger a windows debug job once the PR splitted to make sure the CI is happy about it ?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (fb22661) to head (4f136df).

Additional details and impacted files

@@             Coverage Diff             @@
##           rolling     #317      +/-   ##
===========================================
+ Coverage    88.92%   88.94%   +0.01%     
===========================================
  Files           24       24              
  Lines          614      615       +1     
  Branches        64       64              
===========================================
+ Hits           546      547       +1     
  Misses          50       50              
  Partials        18       18              

Flag	Coverage Δ
unittests	88.94% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clalancette]

however what would you think about making all ARGS keyed-args and keeping the order as is ?

Actually, to be perfectly frank we could just leave the order as-is and remove all of the default arguments. This function is always called with all of its arguments. So I think I'll open a separate PR to do that.

[clalancette]

Here is just CI on Windows Debug. Assuming this is successful, I'll run full CI on it:

• Windows Debug

[clalancette]

And see #318 for the rest of the fixes.

[fujitatomoya]

lgtm with green CI, thanks for the fix.

[clalancette]

And here is full CI:

• Linux
• Linux-aarch64
• Windows

[mikaelarguedas]

Cheers!

[mikaelarguedas]

@Mergifyio backport jazzy

[mergify]

backport jazzy

✅ Backports have been created

• #320 Fix sros2 tests on Windows Debug. (backport #317) has been created for branch jazzy