Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated subscriber callback warnings #483

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Fix deprecated subscriber callback warnings #483

merged 6 commits into from
Aug 26, 2021

Conversation

aprotyas
Copy link
Member

ros2/rclcpp#1713 deprecates the void shared_ptr<T> subscription callback signatures, so this PR migrates away from said signatures.

These patches apply to the following packages:

  • test_communication
  • test_quality_of_service
  • test_security

Signed-off-by: Abrar Rahman Protyasha abrar@openrobotics.org

Fixing deprecated subscriber callback warnings
b21f960 
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
@aprotyas
Copy link
Member Author

Full CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@aprotyas aprotyas mentioned this pull request Aug 20, 2021
Merged
Abrar Rahman Protyasha added 2 commits August 20, 2021 17:53
Fix deprecated sub callbacks in test_rclcpp
1f68dea 
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
Fix deprecated sub callbacks in test_security
48e0323 
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
@aprotyas
Copy link
Member Author

aprotyas commented Aug 21, 2021 •
edited
Loading

Yellow CI for Windows originates from test_security and test_rclcpp packages. The deprecated signatures being used in those packages have been changed in 48e0323 and 1f68dea respectively.

Full CI again:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Abrar Rahman Protyasha and others added 2 commits August 21, 2021 01:17
@wjwwood
Fix line formatting in test_publisher_subscriber
0861228 
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
Co-authored-by: William Woodall <william@osrfoundation.org>
Fix line formatting in some unit tests
cf628b8 
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
@wjwwood
Copy link
Member

wjwwood commented Aug 23, 2021

New CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@aprotyas
Copy link
Member Author

aprotyas commented Aug 23, 2021 •
edited
Loading

Oops, I deleted my forks of robot_state_publisher, ros_tutorials, and interactive_makers after the deprecation PRs were merged in. I just edited the repos file and am running CI again:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented Aug 24, 2021

Looks like there are some uncrustify failures.

@aprotyas
Address ament_uncrustify warnings
414e1c5 
Signed-off-by: aprotyas <aprotyas@u.rochester.edu>
@aprotyas
Copy link
Member Author

aprotyas commented Aug 25, 2021 •
edited
Loading

I addressed the uncrustify warnings in 414e1c5. Running CI again:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@aprotyas aprotyas merged commit fab8e95 into master Aug 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the aprotyas/deprecate-shared-ptr-sub-callback branch August 26, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aprotyas @wjwwood @fujitatomoya