Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range overlaps on boundaries? #92

Closed
lowi opened this issue Sep 3, 2015 · 6 comments
Closed

Range overlaps on boundaries? #92

lowi opened this issue Sep 3, 2015 · 6 comments
Milestone
3.0.0

Comments

@lowi
Copy link

lowi commented Sep 3, 2015

  1. When the end of a range is equal to the start of the next range, shouldn't it overlaps?
    rangeA = moment().range(moment('2015-09-15'), moment('2015-09-16'))
    rangeB = moment().range(moment('2015-09-16'), moment('2015-09-17'))

    rangeA.overlaps(rangeB); // false
    rangeB.overlaps(rangeA); // false

  2. Also rangeA.add(rangeB) does not extend rangeA
@mmakarin mmakarin mentioned this issue Oct 1, 2015
Open
@YagoQuinoy
Copy link

+1

2 similar comments
@coosmiin
Copy link

coosmiin commented Jan 2, 2016

+1

@echogame
Copy link

+1

@DanielSundberg
Copy link

DanielSundberg commented Sep 1, 2016 •
edited
Loading

I would have to disagree. At least when using date and time I think this is correct behavior.

The library I use on my backend (TimePeriodLibrary.Net, http://www.codeproject.com/Articles/168662/Time-Period-Library-for-NET) has the same default behavior (although it can be changed).

gf3 added a commit that referenced this issue Dec 12, 2016
@gf3
Add adjacent method and option to overlaps (#92 #112)
25be063
@gf3
Copy link
Contributor

gf3 commented Dec 12, 2016

great suggestions, i've added both an #adjacent method and an adjacent option to #overlaps in the upcoming release

@gf3 gf3 modified the milestone: 3.0.0 Jan 9, 2017
gf3 added a commit that referenced this issue Jan 10, 2017
@gf3
3.0.0
b78b91b 
* Go full-blown ES6 via webpack/babel
* Flow typing
* Better documentation
* Remove bower
* Remove grunt in favour of webpack
* Remove jshint in favour of eslint
* Remove mocha/should in favour of karma/mocha/expect.js
* New usage:
    import Moment from 'moment';
    import { DateRange, extendMoment } from 'moment-js';
    const moment = extendMoment(Moment);
* Add `by`, `reverseBy`, `byRange`, `reverseByRange` (#68)
    - Pass options as object
    - New methods use iterators
    - Added reversal methods
    - Discrete methods for different iterator types
* Fix issue with `moment#within` and moment-timezone (#127)
* Pass optional rounded argument in `diff` (#104)
* Add ability to iterate over a range by a step (#93)
* Add `adjacent` method and option to `overlaps` (#92 #112)
* Update short-hand units (#134)
* Add `duration` as an alias of `diff` (#64)
* Update packaging rules and scripts
* Fix typo in comment (#133)
* Update documentation
* Add documentation about range creation (thanks @seanwendt)
@gf3
Copy link
Contributor

gf3 commented Jan 10, 2017

just opened a PR for 3.0.0 which incorporates these changes. feel free to leave feedback or raise any questions you may have. thanks again for your contributions

@gf3 gf3 closed this as completed Jan 10, 2017
gf3 added a commit that referenced this issue Jan 10, 2017
@gf3
3.0.0
4270cd2 
* Go full-blown ES6 via webpack/babel
* Flow typing
* Better documentation
* Remove bower
* Remove grunt in favour of webpack
* Remove jshint in favour of eslint
* Remove mocha/should in favour of karma/mocha/expect.js
* New usage:
    import Moment from 'moment';
    import { DateRange, extendMoment } from 'moment-js';
    const moment = extendMoment(Moment);
* Add `by`, `reverseBy`, `byRange`, `reverseByRange` (#68)
    - Pass options as object
    - New methods use iterators
    - Added reversal methods
    - Discrete methods for different iterator types
* Fix issue with `moment#within` and moment-timezone (#127)
* Pass optional rounded argument in `diff` (#104)
* Add ability to iterate over a range by a step (#93)
* Add `adjacent` method and option to `overlaps` (#92 #112)
* Update short-hand units (#134)
* Add `duration` as an alias of `diff` (#64)
* Update packaging rules and scripts
* Fix typo in comment (#133)
* Update documentation
* Add documentation about range creation (thanks @seanwendt)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
6 participants
@gf3 @echogame @lowi @DanielSundberg @YagoQuinoy @coosmiin