-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: iterate over x, not just 1 #93
Milestone
Comments
gf3
added a commit
that referenced
this issue
Dec 8, 2016
awesome suggestion—i've added this functionality to the upcoming v3 release (see the commit above) |
gf3
added a commit
that referenced
this issue
Jan 10, 2017
* Go full-blown ES6 via webpack/babel * Flow typing * Better documentation * Remove bower * Remove grunt in favour of webpack * Remove jshint in favour of eslint * Remove mocha/should in favour of karma/mocha/expect.js * New usage: import Moment from 'moment'; import { DateRange, extendMoment } from 'moment-js'; const moment = extendMoment(Moment); * Add `by`, `reverseBy`, `byRange`, `reverseByRange` (#68) - Pass options as object - New methods use iterators - Added reversal methods - Discrete methods for different iterator types * Fix issue with `moment#within` and moment-timezone (#127) * Pass optional rounded argument in `diff` (#104) * Add ability to iterate over a range by a step (#93) * Add `adjacent` method and option to `overlaps` (#92 #112) * Update short-hand units (#134) * Add `duration` as an alias of `diff` (#64) * Update packaging rules and scripts * Fix typo in comment (#133) * Update documentation * Add documentation about range creation (thanks @seanwendt)
just opened a PR for |
gf3
added a commit
that referenced
this issue
Jan 10, 2017
* Go full-blown ES6 via webpack/babel * Flow typing * Better documentation * Remove bower * Remove grunt in favour of webpack * Remove jshint in favour of eslint * Remove mocha/should in favour of karma/mocha/expect.js * New usage: import Moment from 'moment'; import { DateRange, extendMoment } from 'moment-js'; const moment = extendMoment(Moment); * Add `by`, `reverseBy`, `byRange`, `reverseByRange` (#68) - Pass options as object - New methods use iterators - Added reversal methods - Discrete methods for different iterator types * Fix issue with `moment#within` and moment-timezone (#127) * Pass optional rounded argument in `diff` (#104) * Add ability to iterate over a range by a step (#93) * Add `adjacent` method and option to `overlaps` (#92 #112) * Update short-hand units (#134) * Add `duration` as an alias of `diff` (#64) * Update packaging rules and scripts * Fix typo in comment (#133) * Update documentation * Add documentation about range creation (thanks @seanwendt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I made an adjustment to the iterate feature allowing programmer to control integer in the moment "add" method. Added a "step" argument. Not sure if best way to implement. Starting around line 198 in moment-range.js:
...p.s. I like "hollaback".
The text was updated successfully, but these errors were encountered: