Unbreak CI wheel building on Linux #90
Conversation
|
Something's wrong. The Linux bundling jobs do not bundle the library and the non-bundling job does not create a universal wheel. The macOS build seems to work as expected. |
|
I forgot that the env var might not reach the test. Hm. |
|
Slowly getting there... why did this not turn up before?! |
|
Not really happy with creating a custom Docker wrapper for Linux, but creating an env_vars.sh file on the fly doesn't work... may change it again when I get feedback on https://github.com/matthew-brett/multibuild/issues/183. |
FREETYPEPY_BUNDLE_FT does not reach the container otherwise. Generating an env_vars.sh file doesn't seem to work.
| [ -z "$plat" ] && echo "plat not defined" && exit 1 | ||
| local build_cmds="$2" | ||
| local docker_image=${DOCKER_IMAGE:-quay.io/pypa/manylinux1_\$plat} | ||
| docker_image=$(eval echo "$docker_image") |
|
I haven't deeply looked into this, but honestly, I don't like that you have to basically "fork" parts from multibuild to accomplish such a basic task of passing an environment variable to the docker container. We should ask multibuild maintainers how to best do this. |
|
I did: https://github.com/matthew-brett/multibuild/issues/183 Will change once I hear from them. |
|
https://github.com/rougier/freetype-py/releases/tag/2.0.0.post1 for the title of the Github release notes, it think it's better to keep the same format as the previous ones: e.g. "Version 2.0.0.post1", instead of a descriptive "Fixed CI Linux builds" |
Edit: So, the 2.0 release was botched. The bundling didn't work on Linux because the FREETYPEPY_BUNDLE_FT variable didn't reach the Docker container. This PR makes it work. AppVeyor deployment may need a separate fix.