-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak CI wheel building on Linux #90
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e19f286
Update to multibuild with Python 3.7 support
madig 6536283
Mark (unbundled) wheels as universal
madig f6d4ac1
Recognize PLAT=i686 as PYTHON_ARCH=32
madig fde27e9
Create target library directory before moving SOs there
madig 5c6b382
Do not specify CCACHE for pure wheels, but for macOS build
madig 3964418
Leave note on what entry in Travis matrix is used for what
madig d1bdd28
AppVeyor: print FreeType version before testing
madig 1595a31
Add custom docker wrapper to pass in bundling env var
madig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# Copy of upstream function with added FREETYPEPY_BUNDLE_FT environment var | ||
# passing. | ||
|
||
function build_multilinux { | ||
# Runs passed build commands in manylinux container | ||
# | ||
# Depends on | ||
# MB_PYTHON_VERSION | ||
# UNICODE_WIDTH (optional) | ||
# BUILD_DEPENDS (optional) | ||
# DOCKER_IMAGE (optional) | ||
# MANYLINUX_URL (optional) | ||
# WHEEL_SDIR (optional) | ||
local plat=$1 | ||
[ -z "$plat" ] && echo "plat not defined" && exit 1 | ||
local build_cmds="$2" | ||
local docker_image=${DOCKER_IMAGE:-quay.io/pypa/manylinux1_\$plat} | ||
docker_image=$(eval echo "$docker_image") | ||
retry docker pull $docker_image | ||
|
||
if [ -n "$FREETYPEPY_BUNDLE_FT" ]; | ||
then | ||
docker run --rm \ | ||
-e FREETYPEPY_BUNDLE_FT="1" \ | ||
-e BUILD_COMMANDS="$build_cmds" \ | ||
-e PYTHON_VERSION="$MB_PYTHON_VERSION" \ | ||
-e UNICODE_WIDTH="$UNICODE_WIDTH" \ | ||
-e BUILD_COMMIT="$BUILD_COMMIT" \ | ||
-e CONFIG_PATH="$CONFIG_PATH" \ | ||
-e ENV_VARS_PATH="$ENV_VARS_PATH" \ | ||
-e WHEEL_SDIR="$WHEEL_SDIR" \ | ||
-e MANYLINUX_URL="$MANYLINUX_URL" \ | ||
-e BUILD_DEPENDS="$BUILD_DEPENDS" \ | ||
-e USE_CCACHE="$USE_CCACHE" \ | ||
-e REPO_DIR="$repo_dir" \ | ||
-e PLAT="$PLAT" \ | ||
-v $PWD:/io \ | ||
-v $HOME:/parent-home \ | ||
$docker_image /io/$MULTIBUILD_DIR/docker_build_wrap.sh | ||
else | ||
docker run --rm \ | ||
-e BUILD_COMMANDS="$build_cmds" \ | ||
-e PYTHON_VERSION="$MB_PYTHON_VERSION" \ | ||
-e UNICODE_WIDTH="$UNICODE_WIDTH" \ | ||
-e BUILD_COMMIT="$BUILD_COMMIT" \ | ||
-e CONFIG_PATH="$CONFIG_PATH" \ | ||
-e ENV_VARS_PATH="$ENV_VARS_PATH" \ | ||
-e WHEEL_SDIR="$WHEEL_SDIR" \ | ||
-e MANYLINUX_URL="$MANYLINUX_URL" \ | ||
-e BUILD_DEPENDS="$BUILD_DEPENDS" \ | ||
-e USE_CCACHE="$USE_CCACHE" \ | ||
-e REPO_DIR="$repo_dir" \ | ||
-e PLAT="$PLAT" \ | ||
-v $PWD:/io \ | ||
-v $HOME:/parent-home \ | ||
$docker_image /io/$MULTIBUILD_DIR/docker_build_wrap.sh | ||
fi | ||
} |
Submodule multibuild
updated
12 files
+33 −9 | .travis.yml | |
+44 −9 | common_utils.sh | |
+1 −0 | configure_build.sh | |
+47 −38 | library_builders.sh | |
+8 −5 | osx_utils.sh | |
+56 −0 | tests/test_common_utils.sh | |
+2 −0 | tests/test_fill_pypy_ver.sh | |
+3 −1 | tests/test_fill_pyver.sh | |
+23 −1 | tests/test_library_builders.sh | |
+5 −3 | tests/test_multibuild.sh | |
+1 −1 | tests/test_python_install.sh | |
+1 −1 | travis_linux_steps.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[bdist_wheel] | ||
universal = 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno 😁