Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update users-groups.toml 3proxy #1267

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Update users-groups.toml 3proxy #1267

merged 2 commits into from
Sep 2, 2024

Conversation

13ilya-old
Copy link

Added 3proxy group and user for 3proxy tiny proxy servers set.

Added 3proxy group and user for 3proxy tini proxy servers set.
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this package is not part of Tumbleweed of Leap yet, so I think we shouldn't include.

@13ilya-old
Copy link
Author

13ilya-old commented Aug 21, 2024

As far as I can tell, this package is not part of Tumbleweed of Leap yet, so I think we shouldn't include.

I actually want to include it in rpmlint first, and then add it to Factory.
https://build.opensuse.org/request/show/1197480
I also want to find out if I can use usernames and group names starting with a number?

In Tumbleweed the preinstall script validates them successfully, but Leap won't allow them to be used.

[   21s] ... testing for pre/postinstall scripts that are not idempotent
[   21s] groupadd: '3proxy' is not a valid group name
[   21s] useradd: '3proxy' is not a valid user name
[   21s] preinstall script of 3proxy-0.9.4-lp156.123.1.x86_64.rpm failed

Is the problem with the preinstall script in Leap or should I still not use usernames and group names starting with a number?

@13ilya-old 13ilya-old requested a review from danigm August 21, 2024 11:40
Added proxy user/group for 3proxy.
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks good with the new proxy name.

@danigm danigm merged commit 93edb81 into rpm-software-management:main Sep 2, 2024
13 checks passed
@FilippoBonazziSUSE
Copy link

I think this accidentally went to the main branch instead of the opensuse branch... 😬

@danigm If this is intentional, then can you merge main into opensuse so that we get this change as well?

@danigm
Copy link
Member

danigm commented Sep 18, 2024

I think this accidentally went to the main branch instead of the opensuse branch... 😬

@danigm If this is intentional, then can you merge main into opensuse so that we get this change as well?

Yes, I'll merge main into opensuse today so all the changes to the configs file lands there. We've the configs/openSUSE files so I think it's okay to have these changes also in main branch.

@13ilya-old
Copy link
Author

13ilya-old commented Sep 18, 2024

So I should be submitting this PR to the opensuse branch, not main?

@FilippoBonazziSUSE
Copy link

I think the agreement we have with rpmlint is that our openSUSE-specific changes (whitelistings, ...) should go on the opensuse branch only. I don't think anything bad happened in this case, but perhaps we can still check with the main contributors if e.g. they'd want the change reverted in main.

We want to be upstanding contributors to rpmlint, and not annoy any other contributor. We use rpmlint extensively so we really want to maintain this goodwill.

@13ilya-old
Copy link
Author

13ilya-old commented Sep 18, 2024

It might be worth updating the template of this post to make it clearer where to send PRs.

3proxy.x86_64: W: non-standard-uid /var/lib/3proxy proxy
3proxy.x86_64: W: non-standard-uid /var/lib/3proxy/3proxy.cfg proxy
3proxy.x86_64: W: non-standard-uid /var/log/3proxy proxy
A file in this package is owned by an unregistered user id. To register the
user, please make a pull request to the rpmlint config file
configs/openSUSE/users-groups.toml in the rpmlint repository.

3proxy.x86_64: W: non-standard-gid /var/lib/3proxy proxy
3proxy.x86_64: W: non-standard-gid /var/lib/3proxy/3proxy.cfg proxy
3proxy.x86_64: W: non-standard-gid /var/log/3proxy proxy
A file in this package is owned by an unregistered group id. To register the
group, please make a pull request to the rpmlint config file
configs/openSUSE/users-groups.toml in the rpmlint repository.

@wfrisch
Copy link

wfrisch commented Sep 18, 2024

It might be worth updating the template of this post to make it clearer where to send PRs.

Good idea.
#1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants