-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update users-groups.toml 3proxy #1267
Conversation
Added 3proxy group and user for 3proxy tini proxy servers set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this package is not part of Tumbleweed of Leap yet, so I think we shouldn't include.
I actually want to include it in rpmlint first, and then add it to Factory. In Tumbleweed the preinstall script validates them successfully, but Leap won't allow them to be used.
Is the problem with the preinstall script in Leap or should I still not use usernames and group names starting with a number? |
Added proxy user/group for 3proxy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, looks good with the new proxy
name.
I think this accidentally went to the main branch instead of the opensuse branch... 😬 @danigm If this is intentional, then can you merge main into opensuse so that we get this change as well? |
Yes, I'll merge main into opensuse today so all the changes to the configs file lands there. We've the |
So I should be submitting this PR to the opensuse branch, not main? |
I think the agreement we have with rpmlint is that our openSUSE-specific changes (whitelistings, ...) should go on the opensuse branch only. I don't think anything bad happened in this case, but perhaps we can still check with the main contributors if e.g. they'd want the change reverted in We want to be upstanding contributors to rpmlint, and not annoy any other contributor. We use rpmlint extensively so we really want to maintain this goodwill. |
It might be worth updating the template of this post to make it clearer where to send PRs.
|
Good idea. |
Added 3proxy group and user for 3proxy tiny proxy servers set.