Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensuse: explain pull requests more precisely #1283

Conversation

wfrisch
Copy link

@wfrisch wfrisch commented Sep 18, 2024

i.e. mention our opensuse branch

@wfrisch
Copy link
Author

wfrisch commented Sep 18, 2024

See also the discussion of this PR: #1267

@danigm
Copy link
Member

danigm commented Sep 18, 2024

Tests are failing because the merge from main breaks some of them. I've just fixed it so rebasing this PR should fix the tests

i.e. mention our opensuse branch
@wfrisch wfrisch force-pushed the improve_opensuse_pull_request_instructions branch from f97f94d to 8083a7b Compare September 18, 2024 11:30
@Conan-Kudo
Copy link
Member

I'm starting to wonder if we should pull the openSUSE branch back out again. I wasn't the biggest fan of it when it was instituted, but it's actively confusing to have openSUSE specific PRs here when we went through a lot of effort to make it easier for distro policies to be maintained externally.

@FilippoBonazziSUSE
Copy link

I'll defer the discussion about the opensuse branch to another occasion when at least @jsegitz and @mgerstner can meaningfully participate (they're both unavailable right now).

For me personally the opensuse branch is not confusing and has been working fine for a long time.

Copy link

@FilippoBonazziSUSE FilippoBonazziSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, these changes are a net improvement which is both helpful and uncontroversial. Approving.

@FilippoBonazziSUSE FilippoBonazziSUSE merged commit 5cb5647 into rpm-software-management:opensuse Sep 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants