Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Documentation for Public Methods #197

Open
aphelionz opened this issue Jun 18, 2020 · 2 comments
Open

Documentation for Public Methods #197

aphelionz opened this issue Jun 18, 2020 · 2 comments

Comments

@aphelionz
Copy link
Contributor

aphelionz commented Jun 18, 2020

Rust documentation can be improved overally, but mainly in two places:

  1. Instantiating and setting up an IPFS node
  2. All of the methods in the Ipfs struct, i.e. the main functions that a Rust programmer will use to interact with an IPFS node

To find the remaining places, uncomment src/lib.rs #![warn(missing_docs)].

When developing docs, the docs are catered towards https://docs.rs/ipfs distribution. This basically means generating the docs with the latest nightly (or what docs.rs is using), then running cargo +nightly doc --workspace --no-deps --open. We are still a bit undecided of the #![allow(private_intra_doc_links)] but possibly leaning towards allowing it when it becomes possible with stable rust. So don't worry about cargo +nightly doc warning about private_intra_doc_links.

@koivunej koivunej changed the title Documentation for "Public" Methods Documentation for Public Methods Jun 18, 2020
@koivunej koivunej mentioned this issue Sep 22, 2020
bors bot added a commit that referenced this issue Sep 23, 2020
392: Refresh docs r=koivunej a=koivunej

Adds at least top level documentation for many types, hides some unnecessary re-exports, removes warnings from nightly rustdoc on bad links, and so on.

Cc: #197 (this leaves us with 185 errors)

Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com>
@koivunej
Copy link
Collaborator

After #392 we are now about 60% documented according to docs.rs.

If you are interested in helping out, probably easiest way to find anything to work on is to either:

  • clone, commend out src/lib.rs:18, run cargo check
    • this will produce around 180 errors but works well with rust-analyzer and an IDE
  • browse docs.rs/ipfs

bors bot added a commit that referenced this issue Oct 8, 2020
409: Improve documentation of public methods  r=niklaslong a=niklaslong

This PR goes some way towards improving the documentation of public methods as discussed in #197. 

Co-authored-by: Niklas Long <niklas@equilibrium.co>
@koivunej
Copy link
Collaborator

koivunej commented Oct 8, 2020

Updated the issue description with the nightly/docs.rs hints, lint recommendations.

@koivunej koivunej mentioned this issue Oct 8, 2020
4 tasks
bors bot added a commit that referenced this issue Nov 17, 2020
416: Fix more missing doc warnings r=koivunej a=niklaslong

Follow up to #409 and part of #197.


Co-authored-by: Niklas Long <niklas@equilibrium.co>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants