This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Refresh docs #392
Merged
Refresh docs #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll want to preview this with the #391 in, keeping draft until that. |
ljedrz
reviewed
Sep 22, 2020
ljedrz
reviewed
Sep 22, 2020
not actually sure if this is so bad but ... less warnings.
this seems to still keep Ipfs methods through deref available, lets hope it's the same in docsrs.
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>
koivunej
force-pushed
the
refresh_docs
branch
from
f52cc91 to
ae29c0a
Compare
ljedrz
reviewed
Sep 23, 2020
|
The docs are still looking ok and now have at least top level module writings. I am bit worried docsrs will decide not to show any docs for ipfs::Ipfs since I hid the ipfs::IpfsInner but we'll just have to see. docsrs is using a more recent nightly than I am... but they must have upgraded overnight. Trying now with |
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds at least top level documentation for many types, hides some unnecessary re-exports, removes warnings from nightly rustdoc on bad links, and so on.
Cc: #197 (this leaves us with 185 errors)