This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Remove config file handling #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
force-pushed
the
remove_config_file_handling
branch
from
2b97938 to
1c60859
Compare
ljedrz
approved these changes
Sep 23, 2020
added 2 commits
September 23, 2020 15:33
rationale for `new`: IpfsOptions is already a struct with only pub fields, explaining them again in a doc comment would be useless. rationale for `default`: config file loading is quite out of place being *inside* the library. configuration is an applciation level concern. this also removes UninitializedIpfs::default and replaces their uses with IpfsOptions::inmemory_with_generated_keys or direct struct creation.
rationale: these are now unused, and config handling is best to do at the application level, not in a library.
koivunej
force-pushed
the
remove_config_file_handling
branch
from
1c60859 to
db4f038
Compare
|
Rebased on top of latest master following #394 merge. No surprises. I always want to await for CI but realize it is unnecessary with bors. bors r+ |
|
Cancelled the branch CI. |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wipes out the config handling from
ipfs, IpfsOptions::new, and UninitializedIpfs::default.