Simplified node internals and creation v3 #394
Conversation
|
Git etiquette Q: I should had probably removed those signed offs by @ljedrz? Strange it doesn't get done automatically. Also, I most likely changed how the span is created, or then I just updated to have the default like it's in the latest master. |
koivunej
force-pushed
the
simplified_node
branch
from
c2d65cf to
f6ec5fa
Compare
|
I don't mind the |
|
Waiting for CI, I have two minor doc changes related to the defaults of IpfsOptions::{kad_protocol_name,span} but I'd say this would be ready to go after those. |
... instead of Ipfs. this was the original idea in rs-ipfs#343 perhaps.
|
Now with the |
| use multibase::Base; | ||
| use std::{convert::TryInto, sync::Arc}; | ||
| use tokio::task; | ||
|
|
||
| /// Behaviour type. | ||
| #[derive(NetworkBehaviour)] | ||
| #[derive(libp2p::NetworkBehaviour)] |
There was a problem hiding this comment.
this was done as rust analyzer has this week started having issues with duplicate use's, which I kind of hope will end up being the rustc behaviour in the future as I found this "two items for the same name" confusing as well.
There was a problem hiding this comment.
no downsides to doing it this way 👍
|
windows build agrees (wasn't sure of it) bors r+ |
|
Build succeeded: |
Supercedes #345.
Rebased and fixed on top of #392 master.