Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Release 0.2.0 #356

Closed
24 tasks done
koivunej opened this issue Sep 3, 2020 · 3 comments · Fixed by #400
Closed
24 tasks done

Release 0.2.0 #356

koivunej opened this issue Sep 3, 2020 · 3 comments · Fixed by #400

Comments

@koivunej
Copy link
Collaborator

koivunej commented Sep 3, 2020

It's been literally forever since the last release and we've been discussing this internally. Releasing the crates will allow us to jump into making the docs better through docs.rs visibility and hopefully make the project more accessible through that way as well.

Thinking it's probably best not to even attempt at many last minute polish since we still have a lot of work ahead of us.

@koivunej
Copy link
Collaborator Author

koivunej commented Sep 22, 2020

Updated the list. Expanding thoughts on a few here:

Resolving /dnsaddr/bootstrap.libp2p.io/p2p/$id outside of rust-libp2p: this would be recursive query to find the /ip4 or /ip6 by following TXT fields. The /dnsaddr/bootstrap... could be manually expanded, but the downside is that the ipfs infra team is likely using the dnsaddr to help them manage the system better, and manually expanding would actively work against their freedom to manage the bootstrap node cluster. Though, even at the moment the cluster includes a single peer which is not on the go-ipfs list, unsure why.

Perhaps the easiest is just to keep the single bootstrapper which has the static known ip address.

Rationale for not reloading the config file: We should be getting away from config file implementation in ipfs. While it was necessary in the beginning, library configuration is an application level concern which should be handled by the app. An app can provide which ever kind of nice runtime config reloading or whatnot, however as a library I think ipfs should not strive to support any kinds of concrete configuration persistence strategies.

Removal of public ipns functionality: The flatfs based persistent datastore has never supported ipns nor have ipns records ever been read from the network.

@koivunej koivunej mentioned this issue Sep 22, 2020
bors bot added a commit that referenced this issue Sep 22, 2020
384: remove unimplemented ipns functionalities from Ipfs r=ljedrz a=ljedrz

Remove ipns insertion and cancellation features from `ipfs::Ipfs` (they are not implemented).

Cc #356

Co-authored-by: ljedrz <ljedrz@gmail.com>
bors bot added a commit that referenced this issue Sep 22, 2020
387: fix: restore bootstrappers from static list, update the bootstrapper list r=koivunej a=ljedrz

Alters the `BOOTSTRAP_NODES` list to contain only the currently working addresses and changes the behavior of `Swarm::remove_bootstrappers` to not use the config file, but rather the aforementioned in-memory list.

Cc #356

Co-authored-by: ljedrz <ljedrz@gmail.com>
bors bot added a commit that referenced this issue Sep 22, 2020
383: remove the default random listening address r=ljedrz a=ljedrz

Remove the default random listening address, listen to no addresses by default.

Cc #356

Co-authored-by: ljedrz <ljedrz@gmail.com>
@koivunej
Copy link
Collaborator Author

Edited the list again, adding the README.md example moving and simplification through that.

I also added the src/config.rs removal along with its only dependency IpfsOptions::default(). I've wanted to do this for a while know but forgot about it until it was actually needed in bootstrap_restore. I don't think libraries should ship with config file handling as the topic is too complicated. If some apps want to do bidirectional config file handling they are welcome to do that, but it shouldn't be the goal of ipfs as we already have quite a lot of on our hands.

@koivunej
Copy link
Collaborator Author

Edited list once again, post starting to merge #392 and I had forgotten about #345, added it as a maybe, linked #393.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant