Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

remove the default random listening address #383

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

ljedrz
Copy link
Member

@ljedrz ljedrz commented Sep 22, 2020

Remove the default random listening address, listen to no addresses by default.

Cc #356

Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz ljedrz requested a review from koivunej September 22, 2020 08:08
Copy link
Collaborator

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pub fn inmemory_with_generated_keys() -> Self {
or IpfsOptions::inmemory_with_generated_keys needs to retain that random listening address.

Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
Copy link
Member Author

ljedrz commented Sep 22, 2020

Hmm, the conformance tests need to be adjusted too, either at http config level when profile = test or in index.js.

Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz
Copy link
Member Author

ljedrz commented Sep 22, 2020

In the end the ipfs-http config file needed to be enhanced with the random listening address; the format is compatible with the go-ipfs config file.

Copy link
Collaborator

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, only approving since I am not sure if there are some ordering stuff.

@koivunej koivunej mentioned this pull request Sep 22, 2020
24 tasks
@koivunej koivunej linked an issue Sep 22, 2020 that may be closed by this pull request
@ljedrz
Copy link
Member Author

ljedrz commented Sep 22, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 22, 2020

Build succeeded:

@bors bors bot merged commit bb072f8 into rs-ipfs:master Sep 22, 2020
@ljedrz ljedrz deleted the dont_listen_on_random_addr branch September 22, 2020 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable listening addresses
2 participants