Fix problems with knobs values restore #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #756 and #762 (comment) |
AndyMcFishka
changed the title
-get rid of duplicated refresh midi controller code -fix problem with knob values restore at profile switch -higher priority to alt param value -nil checks fixed
AndyMcFishka
force-pushed
the
fix-knobs-restore-values
branch
from
ee9456c to
2c79fb9
Compare
AndyMcFishka
changed the title
|
Super information! Please let me know the safest way to make these changes? OK - I've swapped files and everything looks promising so far - thanks! |
Glad to hear that it fixed the problem for you. For everybody with the same question - yes, you can replace files and restart plugin, thats all |
rsjaffe
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-get rid of duplicated refresh midi controller code
-fix problem with knob values restore at profile switch
-higher priority to alt param value
-nil checks fixed