Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proj: build tasks for continuous integration #88

Merged
merged 13 commits into from
Dec 30, 2019
Merged

proj: build tasks for continuous integration #88

merged 13 commits into from
Dec 30, 2019

Conversation

bguiz
Copy link
Contributor

@bguiz bguiz commented Dec 30, 2019 •
edited
Loading

What

  • Created a Rakefile with the following capabilities
    • rake prod generates a production build
    • rake dev runs in development mode
    • rake test verifies the generated site locally
      • Via the html-proofer gem, and built-in JSON class
    • updated README to describe new usage
  • Fixed issue with redirects running on localhost, going to hosted domain
    • added _config.localhost.yml for this
  • Fixed multiple existing issues with broken links
    • Several in _layouts and _includes
    • Also added redirects which were expected, but missing
    • Originally there were 1656 failures, now just 104, with the remaining ones expected to be addressed in the issues linked below

Why

  • Automatically detect when a change introduces a broken link
  • Automatically detect when a change introduces a broken search result

Refs

@bguiz bguiz mentioned this pull request Dec 30, 2019
Closed
jonathansmirnoff
jonathansmirnoff approved these changes Dec 30, 2019
View reviewed changes
Copy link
Collaborator

@jonathansmirnoff jonathansmirnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alebanzas alebanzas merged commit 6a94651 into master Dec 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the proj/build-test branch December 30, 2019 13:31
@bguiz bguiz mentioned this pull request Jan 3, 2020
Merged
@bguiz bguiz restored the proj/build-test branch January 4, 2020 10:20
@fedejinich fedejinich deleted the proj/build-test branch February 4, 2020 02:51
@fedejinich fedejinich restored the proj/build-test branch February 4, 2020 02:51
@bguiz bguiz deleted the proj/build-test branch March 18, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathansmirnoff jonathansmirnoff jonathansmirnoff approved these changes

@alebanzas alebanzas alebanzas approved these changes

@vojtechsimetka vojtechsimetka Awaiting requested review from vojtechsimetka

@dulcedu dulcedu Awaiting requested review from dulcedu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bguiz @alebanzas @jonathansmirnoff