Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proj: set up continuous integration #98

Merged
merged 10 commits into from
Jan 3, 2020
Merged

proj: set up continuous integration #98

merged 10 commits into from
Jan 3, 2020

Conversation

bguiz
Copy link
Contributor

@bguiz bguiz commented Jan 3, 2020 •
edited
Loading

What

  • Added a circle CI configuration
  • Updated Gemfile to eliminate inconsistencies between CI and local installations
    • only accept specific version of Ruby
    • specify all dependencies with exact numbers
  • Updated README to update set up instructions and add contribution guidelines

Why

  • From prior PRs proj: build tasks for continuous integration #88 and proj: fix 'rake dev' & move github PR template #97, we have rake test which builds and tests the site
  • We need these tests to
    • be triggered when we push commits to a branch connected to an open pull request
    • be run in a continuous integration environment
  • Set up instruction needs to be updated because Ruby version is now strict, and old instructions will no longer work
  • Contribution guidelines needed to ensure higher quality contributions

Refs

@bguiz bguiz requested review from alebanzas, jjtechuy and a team January 3, 2020 02:01
jjtechuy
jjtechuy approved these changes Jan 3, 2020
View reviewed changes
Copy link

@jjtechuy jjtechuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. All good.

@bguiz bguiz merged commit 5095f59 into master Jan 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the circleci-set-up branch January 3, 2020 13:23
@jjtechuy jjtechuy mentioned this pull request Jan 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjtechuy jjtechuy jjtechuy approved these changes

@alebanzas alebanzas Awaiting requested review from alebanzas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bguiz @jjtechuy