Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proj: fix 'rake dev' & move github PR template #97

Merged
merged 2 commits into from
Jan 2, 2020
Merged

proj: fix 'rake dev' & move github PR template #97

merged 2 commits into from
Jan 2, 2020

Conversation

bguiz
Copy link
Contributor

@bguiz bguiz commented Jan 2, 2020

What

  • Modified _config.localhost.yml used when jekyll is building for dev and test tasks
  • Moved the github PR template

Why

  • The extra config lines were messing up with the dev task beign able to serve files
  • Currently PR template is only used by specifying 'template' query param manually

Refs

  • none

@bguiz bguiz requested review from a team, dulcedu and jonathansmirnoff and removed request for a team January 2, 2020 08:12
@bguiz bguiz merged commit 6546303 into master Jan 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the proj/localhost-config branch January 2, 2020 12:52
@bguiz bguiz mentioned this pull request Jan 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alepc253 alepc253 alepc253 approved these changes

@dulcedu dulcedu Awaiting requested review from dulcedu

@jonathansmirnoff jonathansmirnoff Awaiting requested review from jonathansmirnoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bguiz @alepc253